Closed Bug 335309 Opened 15 years ago Closed 15 years ago

File handle leak in XPCOMGlueLoadDependentLibs (nsXPCOMGlue.cpp)

Categories

(Core Graveyard :: Embedding: GRE Core, defect)

defect
Not set
minor

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: kherron+mozilla, Assigned: rflint)

References

()

Details

(Keywords: coverity, fixed1.8.1)

Attachments

(1 file, 1 obsolete file)

This was found through a coverity scan of the firefox source. Please refer to the sample URL.

The function |XPCOMGlueLoadDependentLibs| calls |fopen| to open a dependent libs file at line 98, reads the file line-by-line, then returns without closing it.
Keywords: coverity
Whiteboard: [good first bug]
Attached patch Close it up! (obsolete) — Splinter Review
Assignee: nobody → rflint
Status: NEW → ASSIGNED
Attachment #219682 - Flags: superreview?(benjamin)
Attachment #219682 - Flags: review?(darin)
Comment on attachment 219682 [details] [diff] [review]
Close it up!

I think you mean fclose(flist), right?
Attachment #219682 - Flags: review?(darin) → review-
Attached patch Patchv2Splinter Review
Whoops :/
Attachment #219682 - Attachment is obsolete: true
Attachment #219709 - Flags: superreview?(benjamin)
Attachment #219709 - Flags: review?(darin)
Attachment #219682 - Flags: superreview?(benjamin)
Attachment #219709 - Flags: review?(darin) → review+
Attachment #219709 - Flags: superreview?(benjamin) → superreview+
Whiteboard: [good first bug] → [checkin needed]
Fixed on trunk.
Status: ASSIGNED → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
And on 1.8.1
Keywords: fixed1.8.1
Whiteboard: [checkin needed]
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.