Closed
Bug 335309
Opened 19 years ago
Closed 19 years ago
File handle leak in XPCOMGlueLoadDependentLibs (nsXPCOMGlue.cpp)
Categories
(Core Graveyard :: Embedding: GRE Core, defect)
Core Graveyard
Embedding: GRE Core
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: kherron+mozilla, Assigned: rflint)
References
()
Details
(Keywords: coverity, fixed1.8.1)
Attachments
(1 file, 1 obsolete file)
|
782 bytes,
patch
|
darin.moz
:
review+
benjamin
:
superreview+
|
Details | Diff | Splinter Review |
This was found through a coverity scan of the firefox source. Please refer to the sample URL.
The function |XPCOMGlueLoadDependentLibs| calls |fopen| to open a dependent libs file at line 98, reads the file line-by-line, then returns without closing it.
|
Assignee | |
Comment 1•19 years ago
|
||
Assignee: nobody → rflint
Status: NEW → ASSIGNED
Attachment #219682 -
Flags: superreview?(benjamin)
Attachment #219682 -
Flags: review?(darin)
|
||
Comment 2•19 years ago
|
||
Comment on attachment 219682 [details] [diff] [review]
Close it up!
I think you mean fclose(flist), right?
Attachment #219682 -
Flags: review?(darin) → review-
|
|
Assignee | |
Comment 3•19 years ago
|
||
Whoops :/
Attachment #219682 -
Attachment is obsolete: true
Attachment #219709 -
Flags: superreview?(benjamin)
Attachment #219709 -
Flags: review?(darin)
Attachment #219682 -
Flags: superreview?(benjamin)
|
|
||
Updated•19 years ago
|
Attachment #219709 -
Flags: review?(darin) → review+
|
||
Updated•19 years ago
|
Attachment #219709 -
Flags: superreview?(benjamin) → superreview+
|
|
Assignee | |
Updated•19 years ago
|
Whiteboard: [good first bug] → [checkin needed]
|
|
||
Comment 4•19 years ago
|
||
Fixed on trunk.
Status: ASSIGNED → RESOLVED
Closed: 19 years ago
Resolution: --- → FIXED
|
||
Updated•8 years ago
|
Product: Core → Core Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•