Closed Bug 335333 Opened 15 years ago Closed 15 years ago

[FIX]Relative, remote images which have a Content-Base fail to display.

Categories

(Core :: DOM: Core & HTML, defect, P1)

Product:
Core
Component:
DOM: Core & HTML
Type:
defect

Tracking

()

Status:
VERIFIED FIXED
Milestone:
mozilla1.9alpha1

People

(Reporter: stephend, Assigned: bzbarsky)

References

Details

(Keywords: regression, verified1.8.0.7, verified1.8.1, Whiteboard: regression from 321299)

Attachments

(1 file)

Fix
3.54 KB, patch
jst
: review+
jst
: superreview+
dveditz
: approval-branch-1.8.1-
dveditz
: approval1.8.0.4-
dveditz
: approval1.8.0.5-
Details | Diff | Splinter Review 
Summary: Relative, remote images which have a Content-Base fail to display.

This probably won't end up in MailNews:Backend as it is currently, but just filing here for now...

Regression Range: Between 2006-04-10-07 and 2006-04-11-10, relative image URIs aren't being resolved nor displayed.

Steps to Reproduce:

1. Go to http://www.iusb.edu
2. In Suite, do a File | Send Page
3. View the mail message (click the "Not a Scam" button and show remote images, if prompted)

Expected Results:

Relative-pathed images such as <img src="foo/bar.gif"> should display, since the message includes both Content-Base and Content-Location fieldsets.

Actual Results:

No relative images display.

The message's HTML content setup is something like this:

Content-Type: text/html; charset=ISO-8859-1;
 name="www.iusb.edu/"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline;
 filename="www.iusb.edu/"
Content-Base: "http://www.iusb.edu/"
Content-Location: "http://www.iusb.edu/"

The actual URI is like:
<img src="img/topnav-right.gif">
This is a regression from bug 321299
Assignee: nobody → general
Blocks: 321299
Component: MailNews: Backend → DOM: Core
OS: Windows XP → All
Priority: -- → P1
QA Contact: ian
Hardware: PC → All
Summary: Relative, remote images which have a Content-Base fail to display. → [FIX]Relative, remote images which have a Content-Base fail to display.
Target Milestone: --- → mozilla1.9alpha
Attached patch Fix — — Splinter Review 
Need to not lose our baseHref property when we get inserted into the document.
Assignee: general → bzbarsky
Status: NEW → ASSIGNED
Attachment #219713 - Flags: superreview?(jst)
Attachment #219713 - Flags: review?(jst)
Comment on attachment 219713 [details] [diff] [review]
Fix

Yeah, duh. r+sr=jst
Attachment #219713 - Flags: superreview?(jst)
Attachment #219713 - Flags: superreview+
Attachment #219713 - Flags: review?(jst)
Attachment #219713 - Flags: review+
Fixed.
Status: ASSIGNED → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
Verified FIXED using build 2006-04-25-18 of SeaMonkey trunk on Windows XP.

Thanks for the quick turnaround, Boris!
Status: RESOLVED → VERIFIED
Flags: blocking1.8.0.4?
Attachment #219713 - Flags: approval1.8.0.4?
Whiteboard: regression from 321299
This is blocking if bug 321299 is
Flags: blocking1.8.0.4? → blocking1.8.0.4+
Comment on attachment 219713 [details] [diff] [review]
Fix

approved for 1.8.0 branch, a=dveditz for drivers
Attachment #219713 - Flags: approval1.8.0.4? → approval1.8.0.4+
Attachment #219713 - Flags: approval-branch-1.8.1+
Flags: blocking1.8.0.5?
Flags: blocking1.8.0.4-
Flags: blocking1.8.0.4+
Comment on attachment 219713 [details] [diff] [review]
Fix

Unapproving for 1.8.0.4 and moving to next release per bug 321299 comment 36
Attachment #219713 - Flags: approval1.8.0.5?
Attachment #219713 - Flags: approval1.8.0.4-
Attachment #219713 - Flags: approval1.8.0.4+
Attachment #219713 - Flags: approval-branch-1.8.1?
Attachment #219713 - Flags: approval-branch-1.8.1+
Flags: blocking1.8.0.5? → blocking1.8.0.5+
Comment on attachment 219713 [details] [diff] [review]
Fix

Jonas says we'll get a combined branch patch for all the related regressions.
Attachment #219713 - Flags: approval1.8.0.5?
Attachment #219713 - Flags: approval1.8.0.5-
Attachment #219713 - Flags: approval-branch-1.8.1?
Attachment #219713 - Flags: approval-branch-1.8.1-
Moving to 1.8.0.6 to follow bug 321299
Flags: blocking1.8.0.6+
Flags: blocking1.8.0.5-
Flags: blocking1.8.0.5+
If bug 321299 is blocking 1.8.1 then this should be also.
Flags: blocking1.8.1?
Flags: blocking1.8.1? → blocking1.8.1+
Target Milestone: mozilla1.9alpha → mozilla1.8.1beta2
Jonas, was this fixed on the branch(es) by bug 321299?
Target Milestone: mozilla1.8.1beta2 → mozilla1.8.1
This was fixed by bug 321299 on the 1.8 branch.
Keywords: fixed1.8.1
Target Milestone: mozilla1.8.1 → mozilla1.9alpha
I checked a combined patch into the 1.8.0 branch.
Keywords: fixed1.8.0.7
verified per comments in 321299 from Blakes comment #13
Keywords: fixed1.8.0.7, fixed1.8.1 → verified1.8.0.7, verified1.8.1
Component: DOM: Core → DOM: Core & HTML
QA Contact: ian → general
You need to log in before you can comment on or make changes to this bug.