335333 - [FIX]Relative, remote images which have a Content-Base fail to display.

Status: VERIFIED FIXED

(Core :: DOM: Core & HTML, defect, P1)

Description

[Stephen Donner [:stephend] Not actively reading bugmail]

Summary: Relative, remote images which have a Content-Base fail to display.

This probably won't end up in MailNews:Backend as it is currently, but just filing here for now...

Regression Range: Between 2006-04-10-07 and 2006-04-11-10, relative image URIs aren't being resolved nor displayed.

Steps to Reproduce:

1. Go to http://www.iusb.edu
2. In Suite, do a File | Send Page
3. View the mail message (click the "Not a Scam" button and show remote images, if prompted)

Expected Results:

Relative-pathed images such as <img src="foo/bar.gif"> should display, since the message includes both Content-Base and Content-Location fieldsets.

Actual Results:

No relative images display.

The message's HTML content setup is something like this:

Content-Type: text/html; charset=ISO-8859-1;
 name="www.iusb.edu/"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline;
 filename="www.iusb.edu/"
Content-Base: "http://www.iusb.edu/"
Content-Location: "http://www.iusb.edu/"

The actual URI is like:
<img src="img/topnav-right.gif">

Comment 1

[Boris Zbarsky [:bzbarsky]]

This is a regression from bug 321299

Comment 2

[Boris Zbarsky [:bzbarsky]]

Attachment: Fix

Need to not lose our baseHref property when we get inserted into the document.

Comment 3

[Johnny Stenback (:jst)]

Comment on attachment 219713 [details] [diff] [review]
Fix

Yeah, duh. r+sr=jst

Comment 4

[Boris Zbarsky [:bzbarsky]]

Fixed.

Comment 5

[Stephen Donner [:stephend] Not actively reading bugmail]

Verified FIXED using build 2006-04-25-18 of SeaMonkey trunk on Windows XP.

Thanks for the quick turnaround, Boris!

Comment 6

[Daniel Veditz [:dveditz]]

This is blocking if bug 321299 is

Comment 7

[Daniel Veditz [:dveditz]]

Comment on attachment 219713 [details] [diff] [review]
Fix

approved for 1.8.0 branch, a=dveditz for drivers

Comment 8

[Daniel Veditz [:dveditz]]

Comment on attachment 219713 [details] [diff] [review]
Fix

Unapproving for 1.8.0.4 and moving to next release per bug 321299 comment 36

Comment 9

[Daniel Veditz [:dveditz]]

Comment on attachment 219713 [details] [diff] [review]
Fix

Jonas says we'll get a combined branch patch for all the related regressions.

Comment 10

[Daniel Veditz [:dveditz]]

Moving to 1.8.0.6 to follow bug 321299

Comment 11

[Daniel Veditz [:dveditz]]

If bug 321299 is blocking 1.8.1 then this should be also.

Comment 12

[Benjamin Smedberg]

Jonas, was this fixed on the branch(es) by bug 321299?

Comment 13

[Blake Kaplan (:mrbkap) (inactive)]

This was fixed by bug 321299 on the 1.8 branch.

Comment 14

[Blake Kaplan (:mrbkap) (inactive)]

I checked a combined patch into the 1.8.0 branch.

Comment 15

[Tracy Walker [:tracy]]

verified per comments in 321299 from Blakes comment #13