Closed
Bug 335421
Opened 19 years ago
Closed 19 years ago
Make FF+XR work on windows
Categories
(Firefox Build System :: General, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: benjamin, Assigned: benjamin)
References
Details
Attachments
(1 file, 1 obsolete file)
|
5.07 KB,
patch
|
mark
:
review+
|
Details | Diff | Splinter Review |
Firefox + XULRunner has some issues on Windows. I'm going to ignore inspector for the moment, but we shouldn't be building the embedding stuff in the browser half of the build, and morkreader linkage is sucky.
|
Assignee | |
Comment 1•19 years ago
|
||
morkreader_s is linked into libxul (for autocomplete import) as well as non-libxul (places import)... I had to build two versions of it.
Attachment #219788 -
Flags: review?(darin)
|
|
Assignee | |
Comment 2•19 years ago
|
||
Darin's out of town, this should be simple. The morkreader/external code can go away again when bug 321219 is fixed.
Attachment #219788 -
Attachment is obsolete: true
Attachment #219873 -
Flags: review?(mark)
Attachment #219788 -
Flags: review?(darin)
|
||
Comment 3•19 years ago
|
||
Comment on attachment 219873 [details] [diff] [review]
Fix morkreader linkage, don't build embedding gunk, rev. 1.1
I don't like the "extenal" thing, but it's fine as a temporary workaround. r=mento.
Attachment #219873 -
Flags: review?(mark) → review+
|
|
Assignee | |
Comment 4•19 years ago
|
||
Fixed on trunk.
Status: NEW → RESOLVED
Closed: 19 years ago
Resolution: --- → FIXED
|
||
Updated•6 years ago
|
Component: Build Config → General
Product: Firefox → Firefox Build System
You need to log in
before you can comment on or make changes to this bug.
Description
•