UI dependencies not working for index() changes

RESOLVED FIXED

Status

Core Graveyard
XForms
RESOLVED FIXED
11 years ago
11 months ago

People

(Reporter: Allan Beaufour, Assigned: Allan Beaufour)

Tracking

({fixed1.8.0.5, fixed1.8.1})

Trunk
fixed1.8.0.5, fixed1.8.1

Firefox Tracking Flags

(Not tracked)

Details

(URL)

Attachments

(2 attachments)

1.88 KB, application/xhtml+xml
Details
4.01 KB, patch
smaug
: review+
Doron Rosenberg (IBM)
: review+
Details | Diff | Splinter Review
(Assignee)

Description

11 years ago
Refreshing controls on index changes are handled by the repeat itself, and I missed that in the UI dependency patch.
(Assignee)

Comment 1

11 years ago
That controls are not bound on form load is bug 335524.
Depends on: 335524
(Assignee)

Comment 2

11 years ago
Created attachment 219877 [details]
Testcase
(Assignee)

Comment 3

11 years ago
(In reply to comment #0)
> Refreshing controls on index changes are handled by the repeat itself, and I
> missed that in the UI dependency patch.

The problem also appears when binding attributes are changed by script. The control refreshes itself, but it needs to refresh children too. I think we need a nsIModelElementPrivate::RebindControl(nsIXFormsControl) that runs the rebind/refresh procedure correctly for that control, and any children too.
Assignee: aaronr → allan
(Assignee)

Comment 4

11 years ago
Created attachment 222873 [details] [diff] [review]
Patch

Tie repeat index() handling to the model UI graph, to let that handle rebinding and refreshing of controls -- properly.
Attachment #222873 - Flags: review?(Olli.Pettay)

Updated

11 years ago
Attachment #222873 - Flags: review?(Olli.Pettay) → review+
(Assignee)

Updated

11 years ago
Attachment #222873 - Flags: review?(doronr)

Updated

11 years ago
Attachment #222873 - Flags: review?(doronr) → review+
(Assignee)

Comment 5

11 years ago
Fixed on trunk
Status: NEW → RESOLVED
Last Resolved: 11 years ago
Resolution: --- → FIXED
Whiteboard: xf-to-branch
(Assignee)

Updated

11 years ago
Keywords: fixed1.8.1
(Assignee)

Updated

11 years ago
Keywords: fixed1.8.0.5
(Assignee)

Updated

11 years ago
Whiteboard: xf-to-branch
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.