"Backup" and "Backup all" should be "Back Up" in the Certificate action menu

RESOLVED FIXED in Camino1.5

Status

Camino Graveyard
Security
--
minor
RESOLVED FIXED
11 years ago
11 years ago

People

(Reporter: Smokey Ardisson (offline for a while; not following bugs - do not email), Assigned: froodian (Ian Leue))

Tracking

({fixed1.8.1.1, polish})

unspecified
Camino1.5
PowerPC
Mac OS X
fixed1.8.1.1, polish

Details

(Whiteboard: [good first bug])

Attachments

(2 attachments, 6 obsolete attachments)

11.72 KB, application/zip
Stuart Morgan
: superreview+
Details
31.85 KB, image/png
Details
From bug 335393:

Someone can file yet another bug about changing "Backup" to "Back Up"

This looks like just a nib change to CertificatesWindow.nib
http://dictionary.reference.com/search?q=backup

i don't think we need to change this. To me "Back Up" means to go backwards, like reverse.

Comment 2

11 years ago
Keep scrolling on that page, Mike, and you'll see this:

backup

<operating system> ("back up" when used as a verb)

Two words as a verb. None of the definitions above that are for verbs; they're all for nouns or adjectives. You can have "backup software" to make a "backup", but that software "backs up" your data. (Note you don't say it "backups" your data.)

cl
you win ;) i concede.

Comment 4

11 years ago
Is this being worked on?  I'm new to contributing and something this minor would be a good place to start.  Can I run with this if it hasn't been assigned?

- Chris

Comment 5

11 years ago
(In reply to comment #4)
> Is this being worked on?  I'm new to contributing and something this minor
> would be a good place to start.  Can I run with this if it hasn't been
> assigned?

Go right ahead, and welcome to the gang!

cl

Comment 6

11 years ago
Thank you.  It will take me some time to get my environment configured, etc, etc, so please be patient with me. :)

- chris
Whiteboard: [good first bug]

Comment 7

11 years ago
Created attachment 227873 [details] [diff] [review]
change "Backup" to "Back Up" in .nib file
Attachment #227873 - Flags: review?(bugzilla)
(Assignee)

Comment 8

11 years ago
Comment on attachment 227873 [details] [diff] [review]
change "Backup" to "Back Up" in .nib file

I'm glad you're interested in helping out, but we don't accept diffs for nib files.  For more info, check out http://wiki.caminobrowser.org/Development:Reviewing (you want to zip the actual nib and attach it here) :)
Attachment #227873 - Flags: review?(bugzilla) → review-

Comment 9

11 years ago
Created attachment 227881 [details]
Reupload CertificatesWindow.nib

Ok, I don't know about this before. Reupload.
Attachment #227873 - Attachment is obsolete: true
Attachment #227881 - Flags: review?(stridey)
Håkan, are we doing the right thing tab-chain wise in this nib (Security prefPane, Certificates button)?  

Seems to me this is just like the Bookmarks Manager, so the views should be getting a focus ring (which would lessen confusion as to why tabbing once--with a Category that has some right-pane content--doesn't focus the first item but requires a down-arrow--again, just like the BM).

Comment 11

11 years ago
This nib worked fine for me, focus-wise. The first listbox is focused (with a blue focus ring), and the listboxes (+  the action button with FKA on) are in the focus chain.
(Assignee)

Comment 12

11 years ago
Comment on attachment 227881 [details]
Reupload CertificatesWindow.nib

Hi Isriya,

This looks good, but it occurs to me that while we're touching this nib, we should make the window comply with our margins standards in http://wiki.caminobrowser.org/Development:Editing_Nibs

Specifically, the action menu button should be 17 px below the view it's under, and the bottom of the window should  be 20 px below that.  Also, the initialFirstResponder should be set to the entire extended split view, and the extended split view and the action menu should each have a nextKeyView of eachother.
Attachment #227881 - Flags: review?(stridey) → review-

Comment 13

11 years ago
Actually, I didn't touch anything in the NIB, just change the string and recompile. mmm... I might accidentially hit it and move. 

Anyway, I'll resubmit this. Thanks for review.

Comment 14

11 years ago
Created attachment 229613 [details]
Reupload CertificatesWindow.nib again

Update NIB file to match Camino Development Guideline.
Attachment #227881 - Attachment is obsolete: true
Attachment #229613 - Flags: review?(stridey)
(Assignee)

Comment 15

11 years ago
Comment on attachment 229613 [details]
Reupload CertificatesWindow.nib again

In this case I would leave initialFirstResponder unset (since that way it does the Right Thing in focusing Category first, instead of focusing the actions menu button).

Also, the actions menu button should only be 17 px below the bottom of of the ExtendedOutlineView (Name, details, expires, etc).

Looking better.
Attachment #229613 - Flags: review?(stridey) → review-
Assignee: nobody → stridey
(Assignee)

Comment 16

11 years ago
Created attachment 247161 [details]
New CertificatesWindow.nib
Attachment #229613 - Attachment is obsolete: true
Attachment #247161 - Flags: review?(alqahira)
(Assignee)

Updated

11 years ago
Status: NEW → ASSIGNED
(Assignee)

Comment 17

11 years ago
Created attachment 247247 [details]
New CertificatesWindow.nib

Increases min width and does a 3px bounding-box adjustment, per IRC.
Attachment #247161 - Attachment is obsolete: true
Attachment #247247 - Flags: review?(alqahira)
Attachment #247161 - Flags: review?(alqahira)
Comment on attachment 247247 [details]
New CertificatesWindow.nib

Nice; r=ardissone

Requesting rs on these cosmetic nib-only changes (per policy).
Attachment #247247 - Flags: superreview?(stuart.morgan)
Attachment #247247 - Flags: review?(alqahira)
Attachment #247247 - Flags: review+

Comment 19

11 years ago
Comment on attachment 247247 [details]
New CertificatesWindow.nib

(In reply to comment #12)
> Specifically, the action menu button should be 17 px below the view it's under,
> and the bottom of the window should  be 20 px below that.

No; this creates a lot of weird dead space at the bottom, and every example of similar controls I can think of looks the way it was before.
Attachment #247247 - Flags: superreview?(stuart.morgan) → superreview-
(In reply to comment #19)
> (From update of attachment 247247 [details] [edit])
> (In reply to comment #12)
> > Specifically, the action menu button should be 17 px below the view it's under,
> > and the bottom of the window should  be 20 px below that.
> 
> No; this creates a lot of weird dead space at the bottom, and every example of
> similar controls I can think of looks the way it was before.

I see nothing in the HIG that supports having a miniscule bottom margin instead of the standard Aqua margins; moreover, it looks out of place in comparison with our cookie sheets, where the button is well-placed.

Comment 21

11 years ago
(In reply to comment #20)
> I see nothing in the HIG that supports having a miniscule bottom margin instead
> of the standard Aqua margins;

The 'G' is for Guidelines; I don't think we should slavishly following margin guidelines that are there solely for aesthetics even when it makes the overall visual appearance worse and more unbalanced.

Note that we also use the current cert spacing in the Bookmark Manager.

> moreover, it looks out of place in comparison with our cookie sheets, where the
> button is well-placed.

We also have an aqua button there, making the space much less empty. If the cert viewer were a sheet with a Done button, then I would agree.
(Assignee)

Comment 22

11 years ago
What about putting the button back close to the table view, but leaving the 20 px between it and the edge of the window?  Although the bookmark manager has dimensions that reflect our currect certificate window, the status bar buffers the edge of the window.  I really think that the 20px around the edge is important.
(Assignee)

Comment 23

11 years ago
Created attachment 247610 [details]
New CertificatesWindow.nib

Does comment 22
Attachment #247247 - Attachment is obsolete: true
Attachment #247610 - Flags: superreview?(stuart.morgan)
(Assignee)

Updated

11 years ago
Attachment #247610 - Flags: superreview?(stuart.morgan)
(Assignee)

Comment 24

11 years ago
Created attachment 247613 [details]
Actually 20 px

Sorry, *this* does comment 22
Attachment #247610 - Attachment is obsolete: true
Attachment #247613 - Flags: review?(stuart.morgan)
(Assignee)

Comment 25

11 years ago
Created attachment 247614 [details]
Screenshot of 247613
(Assignee)

Updated

11 years ago
Attachment #247613 - Flags: review?(stuart.morgan) → superreview?(stuart.morgan)

Comment 26

11 years ago
Comment on attachment 247613 [details]
Actually 20 px

sr=smorgan
Attachment #247613 - Flags: superreview?(stuart.morgan) → superreview+
(Assignee)

Comment 27

11 years ago
Checked in on 1.8branch and trunk.
Status: ASSIGNED → RESOLVED
Last Resolved: 11 years ago
Keywords: fixed1.8.1.1
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.