335738 - migration wizard does not appear after removing user's application support/firefox folder

Status: RESOLVED FIXED

(Firefox :: Migration, defect)

Description

[juan becerra [:juanb]]

User-Agent:       Mozilla/5.0 (Macintosh; U; Intel Mac OS X; en-US; rv:1.8.0.3) Gecko/20060426 Firefox/1.5.0.3
Build Identifier: Mozilla/5.0 (Macintosh; U; Intel Mac OS X; en-US; rv:1.8.0.3) Gecko/20060426 Firefox/1.5.0.3

I was trying one of the installation smoketests which involes removing the Firefox folder from Application Support, which removes the profile, and relaunching the application to see whether the Migration Wizard comes up and prompts you to migrated from Safari or another browser.

Reproducible: Always

Steps to Reproduce:
1. Download the UB from the source above and install it.
2. Launch one first time and quit.
3. Remove the folder Application Support/Firefox from the current user's folder
4. Re-Launch Firefox

Actual Results:  
It just loads a default profile and the migration wizard never shows up.

Expected Results:  
Upon launch Migration Wizard should appear prompting you to migrate data (bookmarks, feeds, etc..) from Safari or any other browser you have installed.

I tried it on new macbook pro and iMac. On the iMac I also tried the latest version from the website 1.5.0.2, and a smilar thing happened.

Comment 1

[Kevin Brosnan]

I see this on the Bon Echo a3 candidate on 10.4.6 too. Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.8.1a3) Gecko/20060526 BonEcho/2.0a3 

Comment 2

[Michael Wu [:mwu]]

Attachment: Fix migration issues on osx

This patch ensures that Safari and MacIE are detected as profiles to migrate on OSX if other (firefox/netscape/opera) browsers aren't installed. It also ensures that future profile migration code gets hooked in properly, assuming the writers of such code read the comments.

Comment 3

[Mike Connor [:mconnor]]

Comment on attachment 225029 [details] [diff] [review]
Fix migration issues on osx

Please get this landed and verified on trunk before requesting branch approval

Comment 4

[Adam Guthrie]

Verified FIXED using Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.9a1) Gecko/20060622 Minefield/3.0a1. 

After moving the Firefox folder in ~/Library/Application support away and launching Firefox the migration wizard does indeed show.

Comment 5

[Michael Wu [:mwu]]

Comment on attachment 225029 [details] [diff] [review]
Fix migration issues on osx

If the user does not have a phoenix, seamonkey, or opera profile already installed, the profile migrator will not show even if there is a Safari (most common case, probably) or a MacIE profile. This is a fairly simple and safe patch, and very important for a good number of people trying Firefox on OSX.

Comment 6

[Mike Schroepfer]

iSpiked you can mark Verified Fixed.

Michael/iSpiked - when you land on 1.8.1 be sure to set the fixed1.8.1 and verified1.8.1 keywords as appropriate.

Comment 7

[Adam Guthrie]

Comment on attachment 225029 [details] [diff] [review]
Fix migration issues on osx

We need to get this fix into 1.8.0 where the bug was originally reported.

Comment 8

[Daniel Veditz [:dveditz]]

Comment on attachment 225029 [details] [diff] [review]
Fix migration issues on osx

approved for 1.8.0 branch, a=dveditz for drivers

Comment 9

[Daniel Veditz [:dveditz]]

Not blocking 1.8.0.x, but we'll take the patch if you get it in before the deadline.

Comment 10

[Michael Wu [:mwu]]

Checking in browser/components/migration/content/migration.xul;
/cvsroot/mozilla/browser/components/migration/content/migration.xul,v  <--  migration.xul
new revision: 1.18.2.4.2.1; previous revision: 1.18.2.4
done
Checking in browser/components/migration/src/nsProfileMigrator.cpp;
/cvsroot/mozilla/browser/components/migration/src/nsProfileMigrator.cpp,v  <--  nsProfileMigrator.cpp
new revision: 1.16.4.1.4.1; previous revision: 1.16.4.1
done

Comment 11

[alice nodelman [:alice] [:anode]]

Mozilla/5.0 (Macintosh; U; Intel Mac OS X; en-US; rv:1.8.0.7pre) Gecko/20060829 Firefox/1.5.0.7pre

verified 1.8.0.7

profile manager is raised if you remove your Firefox/ directory.  profile manager is also raised even if your only other installed browser is safari.