335772 - Button horkage in 3.0a1 Addons

Status: RESOLVED FIXED

(Toolkit :: Add-ons Manager, defect)

Description

[Ed Hume]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a1) Gecko/20060427 Minefield/3.0a1
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a1) Gecko/20060427 Minefield/3.0a1

With system fonts set to Large (125%), the text of certain buttons in the Addons window hangs below the bottom margin of the buttons.

In particular, this happens to the top extension in the Extensions list, and both themes below the default theme in the Themes list.

Reproducible: Always

Steps to Reproduce:
1. Set Windows to Large font size
2. Open Addons window
3.

Actual Results:  
Some buttons are horked

Expected Results:  
Buttons should enlarge to fit the size of text used.

See screenshots:

http://img88.imageshack.us/img88/3630/extensionhork9vf.png
http://img99.imageshack.us/img99/5659/themehork5qs.png

Comment 1

[Ed Hume]

This does not occur where there is a single-line description, and stretching the Extension list window to change a description from two-line to single-line dynamically fixes the problem (this work-around not tested in the Themes window).

Comment 2

[Robert Strong (they/them - no direct email)]

Sounds like this will need to be fixed in XUL Widgets

Comment 3

[dolphinling]

Attachment: Linux screenshot

Here's another screenshot, attached so it doesn't get lost (and it also shows the bug a bit better).

Interestingly, it doesn't change between 2 and 3 lines of content, only between 1 and 2 (not that that probably helps in any way...)

Comment 4

[Robert Strong (they/them - no direct email)]

Try adding the following to your userChrome.css to see if it fixes this... it did for me.

.selectedButtons button {
min-height: 2em !important;
}

If someone could tell me if this occurs on Mac OS X as well it would save me some time. Thanks

Comment 5

[Robert Strong (they/them - no direct email)]

I should say it fixed it for me when I added it to extensions.css and that I haven't tested it with userChrome.css

Comment 6

[Robert Strong (they/them - no direct email)]

Attachment: simple fix (make the min height of the parent 2.1em)

Mike, a simple fix

Comment 7

[Ed Hume]

WFM when added to extension.css.

Comment 8

[Robert Strong (they/them - no direct email)]

Comment on attachment 220102 [details] [diff] [review]
simple fix (make the min height of the parent 2.1em)

Received a verbal + from mconnor since he is in the office today.

Comment 9

[Robert Strong (they/them - no direct email)]

Landed on trunk

Comment 10

[Robert Strong (they/them - no direct email)]

Verbal a+ from bsmedberg... checked in on MOZILLA_1_8_BRANCH

Comment 11

[Boris Zbarsky [:bzbarsky]]

So... won't this break as soon as the description gets to be 3 lines long?

Comment 12

[Boris Zbarsky [:bzbarsky]]

Please, please mark regressions as blocking the bug that caused them.  Saves a lot of trouble when looking at filing bugs on the regressions... 

Comment 13

[Boris Zbarsky [:bzbarsky]]

*** Bug 336438 has been marked as a duplicate of this bug. ***

Comment 14

[Robert Strong (they/them - no direct email)]

(In reply to comment #11)
> So... won't this break as soon as the description gets to be 3 lines long?
No