The default bug view has changed. See this FAQ.

wrapper reparenting leak on gmail

RESOLVED FIXED in mozilla1.8.1

Status

()

Core
XPConnect
--
major
RESOLVED FIXED
11 years ago
11 years ago

People

(Reporter: dbaron, Assigned: dbaron)

Tracking

(4 keywords)

Trunk
mozilla1.8.1
fixed1.8.0.7, fixed1.8.1, mlk, regression
Points:
---
Dependency tree / graph
Bug Flags:
blocking1.8.1 +
blocking1.8.0.4 -
blocking1.8.0.5 -
blocking1.8.0.7 +

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [patch] regression from 333697, regression fix from 321299, URL)

Attachments

(1 attachment)

(Assignee)

Description

11 years ago
A leak in the wrapper reparenting code causes a significant leak of XPCOM objects (including numerous DOM window nsGlobalObject s) by just going to https://mail.google.com/ (when user login is remembered) and closing the browser window.
(Assignee)

Comment 1

11 years ago
Created attachment 220115 [details] [diff] [review]
patch
Assignee: dbradley → dbaron
Status: NEW → ASSIGNED
Attachment #220115 - Flags: superreview?(jst)
Attachment #220115 - Flags: review?(mrbkap)
(Assignee)

Updated

11 years ago
Blocks: 333697
(Assignee)

Updated

11 years ago
Whiteboard: [patch]

Updated

11 years ago
Keywords: mlk
Comment on attachment 220115 [details] [diff] [review]
patch

Darnit. Thanks for finding and fixing this.
Attachment #220115 - Flags: review?(mrbkap) → review+
Comment on attachment 220115 [details] [diff] [review]
patch

sr=jst
Attachment #220115 - Flags: superreview?(jst) → superreview+
(Assignee)

Comment 4

11 years ago
Fix checked in to trunk.
Status: ASSIGNED → RESOLVED
Last Resolved: 11 years ago
Resolution: --- → FIXED

Updated

11 years ago
Keywords: regression
Flags: blocking1.8.0.4+
Comment on attachment 220115 [details] [diff] [review]
patch

How many more of these are there likely to be?
Attachment #220115 - Flags: approval1.8.0.4?
Attachment #220115 - Flags: approval-branch-1.8.1?(jst)
(Assignee)

Comment 6

11 years ago
More of what?  This was a regression from a change two days before; the only other leak on at least basic uses of gmail is bug 206520.
Whiteboard: [patch] → [patch] regression from 333697, regression fix from 321299
Comment on attachment 220115 [details] [diff] [review]
patch

approved for 1.8.0 branch, a=dveditz for drivers
Attachment #220115 - Flags: approval1.8.0.4?
Attachment #220115 - Flags: approval1.8.0.4+
Attachment #220115 - Flags: approval-branch-1.8.1?(jst)
Attachment #220115 - Flags: approval-branch-1.8.1+
Flags: blocking1.8.0.5?
Flags: blocking1.8.0.4-
Flags: blocking1.8.0.4+
Comment on attachment 220115 [details] [diff] [review]
patch

Unapproving for 1.8.0.4 and moving to next release per bug 321299 comment 36
Attachment #220115 - Flags: approval1.8.0.5?
Attachment #220115 - Flags: approval1.8.0.4-
Attachment #220115 - Flags: approval1.8.0.4+
Attachment #220115 - Flags: approval-branch-1.8.1?
Attachment #220115 - Flags: approval-branch-1.8.1+
Flags: blocking1.8.0.5? → blocking1.8.0.5+
Comment on attachment 220115 [details] [diff] [review]
patch

Jonas says we'll get a combined branch patch for all the related regressions.
Attachment #220115 - Flags: approval1.8.0.5?
Attachment #220115 - Flags: approval1.8.0.5-
Attachment #220115 - Flags: approval-branch-1.8.1?
Attachment #220115 - Flags: approval-branch-1.8.1-
Blocks: 321299
Moving to 1.8.0.6 to follow bug 321299
Flags: blocking1.8.0.6+
Flags: blocking1.8.0.5-
Flags: blocking1.8.0.5+
If bug 321299 is blocking 1.8.1 then this should be also.
Flags: blocking1.8.1?

Updated

11 years ago
Flags: blocking1.8.1? → blocking1.8.1+

Updated

11 years ago
Target Milestone: --- → mozilla1.8.1
Jonas, was this fixed by the branch patches in bug 321299?
This was fixed with bug 321299 on the 1.8 branch.
Keywords: fixed1.8.1
I checked a combined patch into the 1.8.0 branch.
Keywords: fixed1.8.0.7
You need to log in before you can comment on or make changes to this bug.