Closed
Bug 335785
Opened 18 years ago
Closed 18 years ago
wrapper reparenting leak on gmail
Categories
(Core :: XPConnect, defect)
Core
XPConnect
Tracking
()
RESOLVED
FIXED
mozilla1.8.1
People
(Reporter: dbaron, Assigned: dbaron)
References
()
Details
(4 keywords, Whiteboard: [patch] regression from 333697, regression fix from 321299)
Attachments
(1 file)
|
1.36 KB,
patch
|
mrbkap
:
review+
jst
:
superreview+
dveditz
:
approval-branch-1.8.1-
dveditz
:
approval1.8.0.4-
dveditz
:
approval1.8.0.5-
|
Details | Diff | Splinter Review |
A leak in the wrapper reparenting code causes a significant leak of XPCOM objects (including numerous DOM window nsGlobalObject s) by just going to https://mail.google.com/ (when user login is remembered) and closing the browser window.
|
Assignee | |
Comment 1•18 years ago
|
||
Assignee: dbradley → dbaron
Status: NEW → ASSIGNED
Attachment #220115 -
Flags: superreview?(jst)
Attachment #220115 -
Flags: review?(mrbkap)
|
|
Assignee | |
Updated•18 years ago
|
Whiteboard: [patch]
|
||
Comment 2•18 years ago
|
||
Comment on attachment 220115 [details] [diff] [review] patch Darnit. Thanks for finding and fixing this.
Attachment #220115 -
Flags: review?(mrbkap) → review+
|
||
Comment 3•18 years ago
|
||
Comment on attachment 220115 [details] [diff] [review] patch sr=jst
Attachment #220115 -
Flags: superreview?(jst) → superreview+
|
|
Assignee | |
Comment 4•18 years ago
|
||
Fix checked in to trunk.
Status: ASSIGNED → RESOLVED
Closed: 18 years ago
Resolution: --- → FIXED
|
||
Updated•18 years ago
|
Keywords: regression
|
||
Updated•18 years ago
|
Flags: blocking1.8.0.4+
|
|
||
Comment 5•18 years ago
|
||
Comment on attachment 220115 [details] [diff] [review] patch How many more of these are there likely to be?
Attachment #220115 -
Flags: approval1.8.0.4?
Attachment #220115 -
Flags: approval-branch-1.8.1?(jst)
|
|
Assignee | |
Comment 6•18 years ago
|
||
More of what? This was a regression from a change two days before; the only other leak on at least basic uses of gmail is bug 206520.
|
|
||
Updated•18 years ago
|
Whiteboard: [patch] → [patch] regression from 333697, regression fix from 321299
|
|
||
Comment 7•18 years ago
|
||
Comment on attachment 220115 [details] [diff] [review] patch approved for 1.8.0 branch, a=dveditz for drivers
Attachment #220115 -
Flags: approval1.8.0.4?
Attachment #220115 -
Flags: approval1.8.0.4+
Attachment #220115 -
Flags: approval-branch-1.8.1?(jst)
Attachment #220115 -
Flags: approval-branch-1.8.1+
|
|
||
Updated•18 years ago
|
Flags: blocking1.8.0.5?
Flags: blocking1.8.0.4-
Flags: blocking1.8.0.4+
|
|
||
Comment 8•18 years ago
|
||
Comment on attachment 220115 [details] [diff] [review] patch Unapproving for 1.8.0.4 and moving to next release per bug 321299 comment 36
Attachment #220115 -
Flags: approval1.8.0.5?
Attachment #220115 -
Flags: approval1.8.0.4-
Attachment #220115 -
Flags: approval1.8.0.4+
Attachment #220115 -
Flags: approval-branch-1.8.1?
Attachment #220115 -
Flags: approval-branch-1.8.1+
|
|
||
Updated•18 years ago
|
Flags: blocking1.8.0.5? → blocking1.8.0.5+
|
|
||
Comment 9•18 years ago
|
||
Comment on attachment 220115 [details] [diff] [review] patch Jonas says we'll get a combined branch patch for all the related regressions.
Attachment #220115 -
Flags: approval1.8.0.5?
Attachment #220115 -
Flags: approval1.8.0.5-
Attachment #220115 -
Flags: approval-branch-1.8.1?
Attachment #220115 -
Flags: approval-branch-1.8.1-
|
|
||
Comment 10•18 years ago
|
||
Moving to 1.8.0.6 to follow bug 321299
Flags: blocking1.8.0.6+
Flags: blocking1.8.0.5-
Flags: blocking1.8.0.5+
|
|
||
Comment 11•18 years ago
|
||
If bug 321299 is blocking 1.8.1 then this should be also.
Flags: blocking1.8.1?
|
||
Updated•18 years ago
|
Flags: blocking1.8.1? → blocking1.8.1+
|
|
||
Updated•18 years ago
|
Target Milestone: --- → mozilla1.8.1
|
||
Comment 12•18 years ago
|
||
Jonas, was this fixed by the branch patches in bug 321299?
You need to log in
before you can comment on or make changes to this bug.
Description
•