Closed
Bug 335800
Opened 19 years ago
Closed 19 years ago
[suiterunner] Alerts lacks application icon on Mac OS X
Categories
(SeaMonkey :: General, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: stefanh, Assigned: kairo)
References
Details
Attachments
(2 files)
|
5.10 KB,
image/png
|
Details | |
|
445 bytes,
patch
|
stefanh
:
review+
neil
:
superreview+
|
Details | Diff | Splinter Review |
icon to put into suite/branding/content
Since suiterunner mac is using Pinstripe's /global directory we need to have an 64x64 application icon (named "icon64.png") in chrome://branding/content/ (see pionstripe/global/global.css line #141).
The corresponding Firefox/Thunderbird icons are to be found at other-licenses/branding/appname/content/.
|
Assignee | |
Comment 1•19 years ago
|
||
|
|
Assignee | |
Updated•19 years ago
|
Attachment #220130 -
Attachment is patch: false
Attachment #220130 -
Attachment mime type: text/plain → image/png
|
|
Assignee | |
Comment 2•19 years ago
|
||
Stefan, could you please try that patch?
I think it should make toolkit alerts work on mac...
Attachment #220131 -
Flags: superreview?(neil)
Attachment #220131 -
Flags: review?(stefanh)
|
Reporter | |
Comment 3•19 years ago
|
||
Comment on attachment 220131 [details] [diff] [review]
add the icon into the branding package
Yep, this makes our toolkit alerts display the app icon. Note that this also seems to cure all the chrome registration errors that I was talking about - not that I can explain why, though...
Attachment #220131 -
Flags: review?(stefanh) → review+
|
||
Updated•19 years ago
|
Attachment #220131 -
Flags: superreview?(neil) → superreview+
|
|
Assignee | |
Comment 4•19 years ago
|
||
Checked into trunk, should be fixed now, hopefully.
Status: NEW → RESOLVED
Closed: 19 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•