Deleting all search engines leaves useless separator in search box dropdown, search bar is useless

VERIFIED FIXED in Firefox 2 beta1

Status

()

Firefox
Search
--
minor
VERIFIED FIXED
12 years ago
11 years ago

People

(Reporter: Gavin, Assigned: mwu)

Tracking

({verified1.8.1})

2.0 Branch
Firefox 2 beta1
verified1.8.1
Points:
---
Bug Flags:
blocking-firefox2 +

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

When all engines are removed using the search manager, the search bar becomes dead UI, and the dropdown contains a useless seperator. Perhaps "Manage Search Engines" should become "Add Engines" in that case, with the extra seperator removed.
Depends on: 232272

Comment 1

12 years ago
The Search button should also become disabled in that case.

Comment 2

12 years ago
blocking nom
Flags: blocking-firefox2?
Keywords: helpwanted
Hmm, kinda edge-to-cornerish, but I'll bite for now.
Flags: blocking-firefox2? → blocking-firefox2+
(Assignee)

Updated

12 years ago
Status: NEW → ASSIGNED
(Assignee)

Updated

12 years ago
Assignee: nobody → michael.wu
Status: ASSIGNED → NEW
(Assignee)

Updated

12 years ago
Whiteboard: [SWAG: 1.5d]

Updated

12 years ago
Target Milestone: --- → Firefox 2 beta1
(Assignee)

Comment 4

12 years ago
Created attachment 225792 [details] [diff] [review]
Make search box act better without any search engines

This eliminates the separator, disables the textbox, makes the search button open manage search engines dialog, and puts the message "No Search Engines Installed" in the textbox when there are no search engines. I don't replace manage engines with add engines because when the button to restore default search engines is added to the manage engines dialog, the user will need to add an engine in order to restore default search engines.
Attachment #225792 - Flags: ui-review?(beltzner)
Attachment #225792 - Flags: review?(gavin.sharp)
Instead of trying to make the search bar useful when there are no engines installed, I think we should just make it impossible to remove all the engines. I can't think of a good reason why someone would want to do that, they can just remove the search bar if they don't want to use it. That's a simpler fix, too: just disable the "remove" button in the engine manager when there's only one engine left.
Yeah, I'll go with that instead!
Comment on attachment 225792 [details] [diff] [review]
Make search box act better without any search engines

I'm with gavin and mconnor :)
Attachment #225792 - Flags: ui-review?(beltzner) → ui-review-
(Assignee)

Comment 8

12 years ago
Created attachment 225883 [details] [diff] [review]
Prevent user from deleting all search engines

Whatever. As long as I get this bug off my list. :p
Attachment #225792 - Attachment is obsolete: true
Attachment #225883 - Flags: review?(gavin.sharp)
Attachment #225792 - Flags: review?(gavin.sharp)
Attachment #225883 - Flags: review?(gavin.sharp) → review+
(Assignee)

Updated

12 years ago
Attachment #225883 - Flags: approval-branch-1.8.1?(mconnor)

Updated

12 years ago
Attachment #225883 - Flags: approval-branch-1.8.1?(mconnor) → approval-branch-1.8.1+

Updated

12 years ago
Keywords: helpwanted
Whiteboard: [SWAG: 1.5d]
Summary: Deleting all search engines leaves useless seperator in search box dropdown, search bar is useless → Deleting all search engines leaves useless separator in search box dropdown, search bar is useless
Patch checked in on branch and trunk.
Status: NEW → RESOLVED
Last Resolved: 12 years ago
Resolution: --- → FIXED
Keywords: fixed1.8.1
Status: RESOLVED → VERIFIED
Keywords: fixed1.8.1 → verified1.8.1
You need to log in before you can comment on or make changes to this bug.