335822 - Deleting all search engines leaves useless separator in search box dropdown, search bar is useless

Status: VERIFIED FIXED

(Firefox :: Search, defect)

Description

[:Gavin Sharp [email: [e-mail]]]

When all engines are removed using the search manager, the search bar becomes dead UI, and the dropdown contains a useless seperator. Perhaps "Manage Search Engines" should become "Add Engines" in that case, with the extra seperator removed.

Comment 1

[Pam Greene]

The Search button should also become disabled in that case.

Comment 2

[Pam Greene]

blocking nom

Comment 3

[Mike Connor [:mconnor]]

Hmm, kinda edge-to-cornerish, but I'll bite for now.

Comment 4

[Michael Wu [:mwu]]

Attachment: Make search box act better without any search engines

This eliminates the separator, disables the textbox, makes the search button open manage search engines dialog, and puts the message "No Search Engines Installed" in the textbox when there are no search engines. I don't replace manage engines with add engines because when the button to restore default search engines is added to the manage engines dialog, the user will need to add an engine in order to restore default search engines.

Comment 5

[:Gavin Sharp [email: [e-mail]]]

Instead of trying to make the search bar useful when there are no engines installed, I think we should just make it impossible to remove all the engines. I can't think of a good reason why someone would want to do that, they can just remove the search bar if they don't want to use it. That's a simpler fix, too: just disable the "remove" button in the engine manager when there's only one engine left.

Comment 6

[Mike Connor [:mconnor]]

Yeah, I'll go with that instead!

Comment 7

[Mike Beltzner [:beltzner, not reading bugmail]]

Comment on attachment 225792 [details] [diff] [review]
Make search box act better without any search engines

I'm with gavin and mconnor :)

Comment 8

[Michael Wu [:mwu]]

Attachment: Prevent user from deleting all search engines

Whatever. As long as I get this bug off my list. :p

Comment 9

[Jeff Walden [:Waldo]]

Patch checked in on branch and trunk.