335875 - Highlighted text doesn't remain highlighted when coming back

Status: RESOLVED WORKSFORME

(Toolkit :: Find Toolbar, defect)

Description

[Jure Repinc (JLP)]

I have this problem with build Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9a1) Gecko/20060428 Minefield/3.0a1

It is always reproducable

Steps to reproduce
1. Go to http://lists.kde.org/?l=kde-commits&r=1&b=200604&w=2
2. Press Ctrl+F and enter kde
3. Select Higlight all
4. Click on a link on that page
5. Go back in history to return to the highlighted page

Actual result:
None of the previously highlighted text is highlighted now

Expected result:
Previously highlighted text should still be highligted when returning back to page.

This worked fine with the nightly build from 2 days ago.

Comment 1

[Jure Repinc (JLP)]

Now it also happened that the highlight stayed when returning back, but the Highlight all button was not yellow. And if I repeatedly tried to click on it the highlight would not togle.

Comment 2

[Adam Guthrie]

Well, nsTypeAheadFind was changed on the 23rd by bug 333896, but I don't think that patch would've caused this regression. Although, if you wanted to, you could see if it did in fact regress because of this patch.

Comment 3

[Jure Repinc (JLP)]

I've compiled a fresh copy of Firefox from CVS (Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9a1) Gecko/20060616 Minefield/3.0a1) and I got this bug on http://archives.mandrivalinux.com/changelog/2006-06/

I opened the quick search toolbar, entered "mdv", selected highlight all, clicked on a link and then went back to the page. All the "mdv"s were highlighted but the highlight button was not yellow. If I pressed it O got this error in console:

WARNING: recurring into frame construction: 'mPresContext->mLayoutPhaseCount[eLayoutPhase_FrameC] == 0', file ../../dist/include/layout/nsPresContext.h, line 84

Toggling the highlight didn't work, "mdv"s always stayed highlighted.

Comment 4

[Peter van der Woude [:Peter6]]

regressionrange comment #0

http://bonsai.mozilla.org/cvsquery.cgi?treeid=default&module=PhoenixTinderbox&branch=HEAD&branchtype=match&dir=&file=&filetype=match&who=&whotype=match&sortby=Date&hours=2&date=explicit&mindate=2006-04-26+04%3A00%3A00&maxdate=2006-04-28+04%3A00%3A00&cvsroot=%2Fcvsroot

Comment 5

[Peter van der Woude [:Peter6]]

Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.9a1) Gecko/20061126 Minefield/3.0a1 ID:2006112602 [cairo]

I see no difference between the 20060426 and later builds

the only "flaw" is when you highlight one item and than press on any link the state of the item goes from Highlighted to Selected before the new page is loaded.

I'm not sure if this is intended or not

Comment 6

[Tracy Walker [:tracy]]

I cannot reproduce this with the latest Firefox trunk build on Linux (FC5) for 20070130. Reporter can you still reproduce with a recent build?

Comment 7

[Adam Guthrie]

Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9a3pre) Gecko/20070217 Minefield/3.0a3pre

Same here, Tracy. Marking as WFM.