Change nsIContent::IsContentOfType to nsINode::IsNodeOfType

VERIFIED FIXED

Status

()

VERIFIED FIXED
13 years ago
8 years ago

People

(Reporter: sicking, Assigned: sicking)

Tracking

Trunk
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments)

I have a patch that moves the IsContentOfType function to nsINode (and renames it appropriately). Most of othe patch is just 

s/IsContentOfType/IsNodeOfType/
s/IsNodeOfType\(nsIContent::/IsNodeOfType\(nsINode::/

The interesting bits are the implementations of IsNodeOfType and the changes to nsINode.h and nsIContent.h
Created attachment 220618 [details] [diff] [review]
Patch to fix

This should take care of it. Most of the patch is just search-n-replace, the interesting parts is in nsINode.h, nsIContent.h and the IsNodeOfType implementations.
Attachment #220618 - Flags: superreview?(bzbarsky)
Attachment #220618 - Flags: review?(bzbarsky)
Comment on attachment 220618 [details] [diff] [review]
Patch to fix

>Index: accessible/src/base/nsAccessible.cpp
> nsIContent *nsAccessible::GetLabelContent(nsIContent 
>+  return aForNode->IsNodeOfType(nsINode::eXUL) ? GetXULLabelContent(aForNode) :
>                                                        GetHTMLLabelContent(aForNode);

Fix the indent?

>Index: gfx/src/x11shared/nsFT2FontCatalog.cpp

I be thinkin' de changez to dis file be a mistake, yes?  Make sure not to land these!

The rest looks good.  r+sr=bzbarsky; I want this in so I can use it in some places in classinfo!
Attachment #220618 - Flags: superreview?(bzbarsky)
Attachment #220618 - Flags: superreview+
Attachment #220618 - Flags: review?(bzbarsky)
Attachment #220618 - Flags: review+
Checked in. Dunno what the change to nsFT2FontCatalog.cpp came from.
Status: NEW → RESOLVED
Last Resolved: 13 years ago
Resolution: --- → FIXED

Comment 4

13 years ago
Created attachment 221257 [details]
IID comment

Do we need to change the comment here?
Yeah, or just nuke it. Mind if I just do that in a later patch?

Comment 6

13 years ago
(In reply to comment #5)
> Yeah, or just nuke it. Mind if I just do that in a later patch?

That's fine.:)
V. based on code inspection.
Assignee: general → jonas
Status: RESOLVED → VERIFIED
QA Contact: ian → general
You need to log in before you can comment on or make changes to this bug.