335911 - Change nsIContent::IsContentOfType to nsINode::IsNodeOfType

Status: VERIFIED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

I have a patch that moves the IsContentOfType function to nsINode (and renames it appropriately). Most of othe patch is just 

s/IsContentOfType/IsNodeOfType/
s/IsNodeOfType\(nsIContent::/IsNodeOfType\(nsINode::/

The interesting bits are the implementations of IsNodeOfType and the changes to nsINode.h and nsIContent.h

Comment 1

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

Attachment: Patch to fix

This should take care of it. Most of the patch is just search-n-replace, the interesting parts is in nsINode.h, nsIContent.h and the IsNodeOfType implementations.

Comment 2

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 220618 [details] [diff] [review]
Patch to fix

>Index: accessible/src/base/nsAccessible.cpp
> nsIContent *nsAccessible::GetLabelContent(nsIContent 
>+  return aForNode->IsNodeOfType(nsINode::eXUL) ? GetXULLabelContent(aForNode) :
>                                                        GetHTMLLabelContent(aForNode);

Fix the indent?

>Index: gfx/src/x11shared/nsFT2FontCatalog.cpp

I be thinkin' de changez to dis file be a mistake, yes?  Make sure not to land these!

The rest looks good.  r+sr=bzbarsky; I want this in so I can use it in some places in classinfo!

Comment 3

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

Checked in. Dunno what the change to nsFT2FontCatalog.cpp came from.

Comment 4

[Alfred Peng]

Attachment: IID comment

Do we need to change the comment here?

Comment 5

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

Yeah, or just nuke it. Mind if I just do that in a later patch?

Comment 6

[Alfred Peng]

(In reply to comment #5)
> Yeah, or just nuke it. Mind if I just do that in a later patch?

That's fine.:)

Comment 7

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

V. based on code inspection.