Closed Bug 335962 Opened 18 years ago Closed 17 years ago

Give the places root folder a name in default_places.html

Categories

(Firefox :: Bookmarks & History, defect, P3)

Product:
Firefox
Component:
Bookmarks & History
Type:
defect

Tracking

()

Status:
RESOLVED INVALID
Milestone:
Firefox 3 alpha2

People

(Reporter: steffen.wilberg, Assigned: dietrich)

References

Details

Attachments

(1 file)

Patch
3.70 KB, patch
Details | Diff | Splinter Review 
The exported bookmarks.html starts like this:

<html><head>
<meta http-equiv="Content-Type" content="text/html; charset=UTF-8"><title>Bookmarks</title></head><body><h1 icon_uri="chrome://browser/skin/places/bookmarksMenu.png">Bookmarks Menu</h1>

<dl><p>
    </p><dt></dt><h3 places_root="true"></h3>
    <dl><p>
        </p><dt><a href="place:&amp;beginTimeRef=1&amp;endTimeRef=2&amp;sort=4&amp;type=1">History</a>
        </dt><dt><a href="place:&amp;annotation=livemark%2FfeedURI">Subscriptions</a>
Er, View Selection Source messed this up.

<!DOCTYPE NETSCAPE-Bookmark-file-1>
<META HTTP-EQUIV="Content-Type" CONTENT="text/html; charset=UTF-8">
<TITLE>Bookmarks</TITLE>
<H1 ICON_URI="chrome://browser/skin/places/bookmarksMenu.png">Bookmarks Menu</H1>

<DL><p>
    <DT><H3 PLACES_ROOT="true"></H3>
    <DL><p>
        <DT><A HREF="place:&beginTimeRef=1&endTimeRef=2&sort=4&type=1">History</A>
        <DT><A HREF="place:&annotation=livemark%2FfeedURI">Subscriptions</A>
This is basically the design. This item is the "places root" that appears on the left side of the places pane. We should probably give it a name in the default_places.html, even though you never see it in the UI.
Assignee: nobody → brettw
OS: Windows XP → All
Summary: bookmarks export creates an unnamed folder with "History" and "Subscriptions" → Give the places root folder a name in default_places.html
*** Bug 335996 has been marked as a duplicate of this bug. ***
Version: unspecified → Trunk
Attached patch Patch — — Splinter Review 
This causes the title of the places root to be imported for a new or migrated profile. You won't see any change if you use an old profile for export.
Attachment #220838 - Flags: review?(joe)
Priority: -- → P3
Hardware: PC → All
Target Milestone: --- → Firefox 3 alpha2
Assignee: brettw → nobody
Attachment #220838 - Flags: review?(joe)
default_places.html should be going away on the trunk.
Blocks: 371926
(In reply to comment #5)
> default_places.html should be going away on the trunk.
> 

once bug 349253 lands, we can add a title via the default properties.
Depends on: 349253
Assignee: nobody → dietrich
Depends on: 376008
default_places.html no longer exists, and we don't export the places root in bookmarks.html, so marking invalid.
Status: NEW → RESOLVED
Closed: 17 years ago
Resolution: --- → INVALID
Bug 451915 - move Firefox/Places bugs to Firefox/Bookmarks and History. Remove all bugspam from this move by filtering for the string "places-to-b-and-h".

In Thunderbird 3.0b, you do that as follows:
Tools | Message Filters
Make sure the correct account is selected. Click "New"
Conditions: Body   contains   places-to-b-and-h
Change the action to "Delete Message".
Select "Manually Run" from the dropdown at the top.
Click OK.

Select the filter in the list, make sure "Inbox" is selected at the bottom, and click "Run Now". This should delete all the bugspam. You can then delete the filter.

Gerv
Component: Places → Bookmarks & History
QA Contact: places → bookmarks
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: