Closed Bug 335966 Opened 18 years ago Closed 18 years ago

http error responses should be considered upload failures

Categories

(Toolkit Graveyard :: Data Collection/Metrics, defect)

Product:
Toolkit Graveyard
Component:
Data Collection/Metrics
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: bryner, Assigned: bryner)

Details

Attachments

(1 file)

check for error response
5.87 KB, patch
Details | Diff | Splinter Review
Blocks: 328064
This has a few misc. changes to go along with the http response code check:
- Move cancellation of the upload timer from quit-application to xpcom-shutdown.  This seems to be necessary since in the app-restart case we never see quit-application and our upload timer fires as the event queue is flushed, causing us to try to use the DOMSerializer after it's no longer safe to do so.
- Factored out the looping call to PR_GetRandomNoise and use it in the client id generation code as well.
Assignee: nobody → bryner
Status: NEW → ASSIGNED
Attachment #220465 - Flags: first-review?(darin)
Attachment #220465 - Flags: first-review?(darin) → first-review+
checked in
Status: ASSIGNED → RESOLVED
Closed: 18 years ago
Resolution: --- → FIXED
No longer blocks: 328064
Flags: first-review+
Product: Toolkit → Toolkit Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: