http error responses should be considered upload failures

RESOLVED FIXED

Status

RESOLVED FIXED
13 years ago
8 years ago

People

(Reporter: bryner, Assigned: bryner)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

13 years ago
 
(Assignee)

Updated

13 years ago
Blocks: 328064
(Assignee)

Comment 1

13 years ago
Created attachment 220465 [details] [diff] [review]
check for error response

This has a few misc. changes to go along with the http response code check:
- Move cancellation of the upload timer from quit-application to xpcom-shutdown.  This seems to be necessary since in the app-restart case we never see quit-application and our upload timer fires as the event queue is flushed, causing us to try to use the DOMSerializer after it's no longer safe to do so.
- Factored out the looping call to PR_GetRandomNoise and use it in the client id generation code as well.
Assignee: nobody → bryner
Status: NEW → ASSIGNED
Attachment #220465 - Flags: first-review?(darin)

Updated

13 years ago
Attachment #220465 - Flags: first-review?(darin) → first-review+
(Assignee)

Comment 2

13 years ago
checked in
Status: ASSIGNED → RESOLVED
Last Resolved: 13 years ago
Resolution: --- → FIXED
(Assignee)

Updated

13 years ago
No longer blocks: 328064

Updated

8 years ago
Component: Data Collection/Metrics → Data Collection/Metrics
Flags: first-review+
Product: Toolkit → Toolkit Graveyard
You need to log in before you can comment on or make changes to this bug.