Closed Bug 335983 Opened 15 years ago Closed 15 years ago
Certain translations mis-localize the Go menu date string
The Go menu date string (aka HistoryMenuDateFormat, from bug 299757) is supposed to include only Day of the Week, Day, and Month (in whatever order is appropriate for the language; in English, it is "Monday, April 24"); we're using the localizable.string specifically to *not* show the year there. Some languages (at least French; I haven't checked others) are mis-localizing that string to include the year. For the sake of consistency (and because having the year show up on folders between "Yesterday" and "More than a Week Ago" just looks silly), the year shouldn't be there. We should do 2 things here: 1) Ludo/Marcello clarify the items that should be in that string to the l10n teams 2) We add a better comment to the English localizable.strings file that also clarifies this, for new localizations and the future (i.e., doing this will make this bug FIXED) Target on this is 1.1; we want to try to stay string-frozen for 1.0.x if at all possible, I think.
I'll keep the ML guys alerted, so if there'll be a 1.0.2 we'll be ready for that, as well.
Current comment is: /* most likely the only thing you need to do here is change the ordering */ "HistoryMenuDateFormat" = "%A, %B %d"; I propose to add, either on a second line or as an extension of the existing comment: The string should only include the day of the week, day, and month. Does that sound good to everyone?
(In reply to comment #2) > Does that sound good to everyone? > yes. Also we should document that a bit more on caminol10n.
Simon, it that text OK with you? If so, I'll get someone to check in a changed Localizable.strings file.
Sure. Bonus points if the comment says what %A, %B and %d mean.
(In reply to comment #2) > Current comment is: > > /* most likely the only thing you need to do here is change the ordering */ > "HistoryMenuDateFormat" = "%A, %B %d"; > > I propose to add, either on a second line or as an extension of the existing > comment: > > The string should only include the day of the week, day, and month. > > > Does that sound good to everyone? > Well in my p.o.v. for Portuguese (pt-PT) this should be "%A, %d de %B", and it's fairly acceptable this is also true for all latin derived languages such as Portuguese, Portuguese-Brazilian, Spanhish, French, and Italian. By the way, in chance of capitalizing the fist letter of day-of-week and month ? That would be super. -- Paulo Nascimento
Since there are some bugs with strings changes going to be landing soon, I wanted to finalize the "comment text with bonus points" ;) Any objections to having the new additional comment for the string be: The string should only include the name of the day of the week (%A), day of the month as a number (%d), and name of the month (%B). -- Also, Paolo/Steve, the capitalization comes from the OS, and I'd be concerned if the OS is giving them to you in the wrong case for your locale. You can (and should) adjust the punctuation and any prepositions/articles when localizing the string, of course.
hwaara checked this string in today.
Status: NEW → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.