Closed
Bug 336045
Opened 19 years ago
Closed 19 years ago
Undeclared variables endDate, testDate in calDateTimeFormatter.formatInterval
Categories
(Calendar :: General, defect)
Calendar
General
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: gekacheka, Unassigned)
Details
Attachments
(1 file)
956 bytes,
patch
|
mvl
:
first-review+
|
Details | Diff | Splinter Review |
User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.8.0.2) Gecko/20060308 Firefox/1.5.0.2
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.9a1) Gecko/20060429 CalendarItemDialog/0.0.6 Mozilla Sunbird/0.3a2
Undeclared variables endDate, testDate in calDateTimeFormatter.formatInterval
Reproducible: Always
Steps to Reproduce:
1. start sunbird (with venkman installed)
2. open venkman
3. mouseover preview in
(Preference javascript.options.strict is true)
Actual Results:
Venkman shows warnings
Warning ``assignment to undeclared variable endDate'' [xs] in file ``file:///C:/moz/sunbird/components/calDateTimeFormatter.js'', line 175, character 0.
Warning ``assignment to undeclared variable testdate'' [xs] in file ``file:///C:/moz/sunbird/components/calDateTimeFormatter.js'', line 183, character 0.
(No warnings appear in Javascript console)
Expected Results:
No warnings
(Also, when there are warnings, they should appear in Javascript console)
Q. Why didn't these errors show up in the JavaScript console (even with strict checking enabled) ? Does it have something to do with running as a component/service? Should that be a separate bug?
(patch -l -p 2 -i file.patch)
Attachment #220340 -
Flags: first-review?(mvl)
Attachment #220340 -
Attachment filename: bug336045calStorageUndeclaredVars.patch → bug336045calDateTimeFormatterUndeclaredVars.patch
Comment 2•19 years ago
|
||
Comment on attachment 220340 [details] [diff] [review]
add 'var' to declare endDate, testDate
r=mvl
Attachment #220340 -
Flags: first-review?(mvl) → first-review+
Updated•19 years ago
|
Whiteboard: [needs landing]
Comment 3•19 years ago
|
||
Patch checked in to trunk and MOZILLA_1_8_BRANCH
Status: NEW → RESOLVED
Closed: 19 years ago
Resolution: --- → FIXED
Whiteboard: [needs landing]
You need to log in
before you can comment on or make changes to this bug.
Description
•