336194 - getPagesWithAnnotation throws exception if there are no pages with that annotation

Status: RESOLVED WORKSFORME

(Firefox :: Bookmarks & History, defect, P3)

Description

[Myk Melez [:myk] [@mykmelez]]

In my debug trunk build, if I call getPagesWithAnnotation for an annotation that isn't currently annotating any pages, two annotation service warnings pop up on my console, and then the annotation service throws an exception:

WARNING: NS_ENSURE_TRUE(NS_SUCCEEDED(rv)) failed: file nsAnnotationService.cpp, line 565
WARNING: NS_ENSURE_TRUE(NS_SUCCEEDED(rv)) failed: file nsAnnotationService.cpp, line 521
************************************************************
* Call to xpconnect wrapped JSObject produced this error:  *
[Exception... "Component returned failure code: 0x804b000a [nsIAnnotationService.getPagesWithAnnotation]"  nsresult: "0x804b000a (<unknown>)"  location: "JS frame :: file:///home/myk/Projects/firefox-trunk/mozilla/dist/bin/components/nsMicrosummaryService.js :: MSS__updateMicrosummaries :: line 177"  data: no]
************************************************************

If I then add an annotation with the given name to a page and repeat the call to getPagesWithAnnotation, the warnings don't appear, and the exception doesn't get thrown.

Comment 1

[Marco Bonardo [:mak]]

i've seen that the code changed there, does this happens yet?
i've tried to reproduce but can't

Comment 2

[Myk Melez [:myk] [@mykmelez]]

No, this doesn't seem to happen anymore.

Comment 3

[Gervase Markham [:gerv]]

Bug 451915 - move Firefox/Places bugs to Firefox/Bookmarks and History. Remove all bugspam from this move by filtering for the string "places-to-b-and-h".

In Thunderbird 3.0b, you do that as follows:
Tools | Message Filters
Make sure the correct account is selected. Click "New"
Conditions: Body   contains   places-to-b-and-h
Change the action to "Delete Message".
Select "Manually Run" from the dropdown at the top.
Click OK.

Select the filter in the list, make sure "Inbox" is selected at the bottom, and click "Run Now". This should delete all the bugspam. You can then delete the filter.

Gerv