336198 - Leak in NSResOpenTable & NSResCreateTable (dbm/src/nsres.c)

Status: RESOLVED FIXED

(NSS :: Libraries, defect, P2)

Description

[Kenneth Herron]

Please refer to the sample URL. In function |NSResCreateTable| at line 82, a block of memory is allocated into |hres|. At lines 100-101, if the |dbopen| operation fails, the function returns without freeing this memory.

An identical pattern appears in |NSResOpenTable| beginning at line 113.

Comment 1

[Ryan Flint [:rflint] (ping via IRC for reviews)]

Attachment: Free hres

Comment 2

[Wan-Teh Chang]

I believe mozilla/dbm/src/nsres.c is dead code
because I verified that all the functions defined in
nsres.c are declared in nsres.h, and no files in the
Mozilla source tree include nsres.h:

http://lxr.mozilla.org/seamonkey/search?string=nsres.h
http://lxr.mozilla.org/mozilla1.8/search?string=nsres.h
http://lxr.mozilla.org/mozilla1.8.0/search?string=nsres.h
http://lxr.mozilla.org/mozilla1.7/search?string=nsres.h
http://lxr.mozilla.org/aviary101branch/search?string=nsres.h

So I suggest that we cvs remove nsres.c and nsres.h.

Comment 3

[Nelson Bolyard (seldom reads bugmail)]

> So I suggest that we cvs remove nsres.c and nsres.h.
I second that motion.

Comment 4

[Nelson Bolyard (seldom reads bugmail)]

Ryan, would you like to verify that your tree still builds completely with 
nsres.[ch] removed from it?

Comment 5

[Nelson Bolyard (seldom reads bugmail)]

Attachment: remove file names from manifest.mn files

Comment 6

[Nelson Bolyard (seldom reads bugmail)]

Christophe: 
Please look and see if the removal of these two source files, including one
formerly public header file, will cause any angst.  Advise us on what you find.

Comment 7

[Christophe Ravel]

We don't deliver nsres.h so we can remove it without any impact on our delivery.

Comment 8

[Nelson Bolyard (seldom reads bugmail)]

committed on branch.
Checking in include/manifest.mn;  new revision: 1.2.20.1; previous revision: 1.2
Checking in src/manifest.mn;      new revision: 1.4.16.1; previous revision: 1.4

Comment 9

[Nelson Bolyard (seldom reads bugmail)]

Checked in on trunk
include/manifest.mn; new revision: 1.3; previous revision: 1.2
    src/manifest.mn; new revision: 1.5; previous revision: 1.4

Comment 10

[Nelson Bolyard (seldom reads bugmail)]

Files CVS removed from trunk
Removing include/nsres.h; new revision: delete; previous revision: 3.2
Removing     src/nsres.c; new revision: delete; previous revision: 3.6

Comment 11

[Nelson Bolyard (seldom reads bugmail)]

Files removed from NSS_3_11_BRANCH
Removing include/nsres.h; new revision: delete; previous revision: 3.2
Removing src/nsres.c;     new revision: delete; previous revision: 3.6

Comment 12

[Nelson Bolyard (seldom reads bugmail)]

CIDs 30 66 67