Closed Bug 336221 Opened 15 years ago Closed 15 years ago

Remove 10.2-only code/checks in NSWorkspace+Utils.m

Categories

(Camino Graveyard :: General, defect)

PowerPC
macOS
defect
Not set
normal

Tracking

(Not tracked)

VERIFIED FIXED
Camino1.5

People

(Reporter: alqahira, Assigned: froodian)

References

()

Details

(Keywords: fixed1.8.1)

Attachments

(1 file)

I noticed when mxring the min-version warning code that there are some 10.2 checks in NSWorkspace+Utils.m (part of the Bonjour check) that can be removed.

It also looks like part of the code that builds the list of browsers to offer as default browser is using a function for 10.2 compatibility where a 10.3-and-above function was more desireable, http://landfill.mozilla.org/mxr-test/mozilla/source/camino/src/extensions/NSWorkspace+Utils.m#49
Attached patch PatchSplinter Review
Removes the check to make sure we're 10.3+ for bonjour.

This doesn't make the other change mentioned in comment 0 (replacing _LSCopyApplicationURLsForItemURL with LSCopyApplicationURLsForURL) because when I do that I get an undefined symbol error.  If it's something obvious, I'm happy to make the change, but otherwise I think it should be filed as a followup bug, since it's not really what this bug is about.
Assignee: nobody → stridey
Status: NEW → ASSIGNED
Attachment #226040 - Flags: review?(mozilla)
Comment on attachment 226040 [details] [diff] [review]
Patch

Looks good to me.
Attachment #226040 - Flags: review?(mozilla) → review+
Attachment #226040 - Flags: superreview?(mark)
Comment on attachment 226040 [details] [diff] [review]
Patch

LSCopyApplicationURLsForURL will need to wait until we move to the 10.3 SDK.
Attachment #226040 - Flags: superreview?(mark) → superreview+
Whiteboard: [needs checkin]
Fixed trunk and branch.
Status: ASSIGNED → RESOLVED
Closed: 15 years ago
Keywords: fixed1.8.1
Resolution: --- → FIXED
Whiteboard: [needs checkin]
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.