336221 - Remove 10.2-only code/checks in NSWorkspace+Utils.m

Status: VERIFIED FIXED

(Camino Graveyard :: General, defect)

Description

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

I noticed when mxring the min-version warning code that there are some 10.2 checks in NSWorkspace+Utils.m (part of the Bonjour check) that can be removed.

It also looks like part of the code that builds the list of browsers to offer as default browser is using a function for 10.2 compatibility where a 10.3-and-above function was more desireable, http://landfill.mozilla.org/mxr-test/mozilla/source/camino/src/extensions/NSWorkspace+Utils.m#49

Comment 1

[froodian (Ian Leue)]

Attachment: Patch

Removes the check to make sure we're 10.3+ for bonjour.

This doesn't make the other change mentioned in comment 0 (replacing _LSCopyApplicationURLsForItemURL with LSCopyApplicationURLsForURL) because when I do that I get an undefined symbol error.  If it's something obvious, I'm happy to make the change, but otherwise I think it should be filed as a followup bug, since it's not really what this bug is about.

Comment 2

[Wevah (Nate Weaver)]

Comment on attachment 226040 [details] [diff] [review]
Patch

Looks good to me.

Comment 3

[Mark Mentovai]

Comment on attachment 226040 [details] [diff] [review]
Patch

LSCopyApplicationURLsForURL will need to wait until we move to the 10.3 SDK.

Comment 4

[Nick Kreeger]

Fixed trunk and branch.