Closed
Bug 336230
Opened 19 years ago
Closed 19 years ago
doubtful ASYNC_SYNC case
Categories
(Core :: SQLite and Embedded Database Bindings, defect, P1)
Core
SQLite and Embedded Database Bindings
Tracking
()
RESOLVED
FIXED
mozilla1.8.1beta1
People
(Reporter: sync2d, Assigned: brettw)
References
Details
(Keywords: dataloss, fixed1.8.1)
Attachments
(1 file)
|
1.14 KB,
patch
|
vlad
:
approval-branch-1.8.1+
|
Details | Diff | Splinter Review |
http://lxr.mozilla.org/seamonkey/source/storage/src/mozStorageAsyncIO.cpp#1312
1312 case ASYNC_SYNC:
1313 NS_ASSERTION(pBase, "Must have base writer for writing");
1314 NS_ASSERTION(sqliteOrigTruncate, "No seek pointer");
1315 rc = sqliteOrigSeek(pBase, aMessage->mOffset);
1316 break;
The second assertion has an expr and message inconsistent.
Calling sqliteOrigSeek() for ASYNC_SYNC seems to be an error.
And, the argument for ASYNC_SYNC is mBytes but not mOffset.
|
Assignee | |
Updated•19 years ago
|
Assignee: vladimir → brettw
|
|
Assignee | |
Updated•19 years ago
|
Priority: -- → P1
Target Milestone: --- → mozilla1.8.1beta1
|
|
Assignee | |
Comment 1•19 years ago
|
||
This would cause the possibility of losing data (for places, bookmarks and history) on crash.
Flags: blocking-firefox2?
Keywords: dataloss
|
|
Assignee | |
Comment 2•19 years ago
|
||
shutdown@flashmail.com: Thanks for finding this bug!
Attachment #222553 -
Flags: first-review?(vladimir)
Attachment #222553 -
Flags: approval-branch-1.8.1?(vladimir)
|
|
Assignee | |
Updated•19 years ago
|
Whiteboard: has patch
Comment on attachment 222553 [details] [diff] [review]
Patch
Youch. r+a=me
Attachment #222553 -
Flags: first-review?(vladimir)
Attachment #222553 -
Flags: first-review+
Attachment #222553 -
Flags: approval-branch-1.8.1?(vladimir)
Attachment #222553 -
Flags: approval-branch-1.8.1+
|
|
Assignee | |
Comment 4•19 years ago
|
||
Fixed on trunk and 1.8 branch.
|
|
Assignee | |
Comment 5•19 years ago
|
||
Backed out of branch because tree was closed. Reopening so I remember to re-check in when branch is open. It's still on trunk.
|
|
Assignee | |
Comment 6•19 years ago
|
||
Fixed on branch again.
Status: REOPENED → RESOLVED
Closed: 19 years ago → 19 years ago
Keywords: fixed1.8.1
Resolution: --- → FIXED
Whiteboard: has patch
|
|
||
Updated•19 years ago
|
Flags: blocking-firefox2? → blocking-firefox2+
|
||
Updated•1 year ago
|
Product: Toolkit → Core
You need to log in
before you can comment on or make changes to this bug.
Description
•