[FIX]nsPrincipal::GetOrigin should dig into nested URIs

RESOLVED FIXED in mozilla1.9alpha1

Status

()

Core
Security
P2
normal
RESOLVED FIXED
11 years ago
9 years ago

People

(Reporter: bz, Assigned: bz)

Tracking

({fixed1.8.0.15, verified1.8.1.13})

Trunk
mozilla1.9alpha1
x86
Linux
fixed1.8.0.15, verified1.8.1.13
Points:
---
Dependency tree / graph
Bug Flags:
blocking1.8.1.13 +
blocking1.8.0.next +

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments, 2 obsolete attachments)

That would allow us to remove the "ugly manual de-nesting of jar: in
nsScriptSecurityManager::LookupPolicy".
Blocks: 327241
Depends on: 334407
Created attachment 220558 [details] [diff] [review]
Proposed fix

I checked the GetOrigin callers.  All except for GetCodebasePrincipal are just fine with this change; I believe GetCodebasePrincipal is fine too.
Attachment #220558 - Flags: superreview?(jst)
Attachment #220558 - Flags: review?(dveditz)
Priority: -- → P2
Summary: nsPrincipal::GetOrigin should dig into nested URIs → [FIX]nsPrincipal::GetOrigin should dig into nested URIs
Target Milestone: --- → mozilla1.9alpha
Comment on attachment 220558 [details] [diff] [review]
Proposed fix

presumably there's a caps/include/nsPrincipal.h patch that adds the mOrigin member?

r=dveditz
Attachment #220558 - Flags: review?(dveditz) → review+
Created attachment 220780 [details] [diff] [review]
Er, yes.  ;)
Attachment #220558 - Attachment is obsolete: true
Attachment #220780 - Flags: superreview?(jst)
Attachment #220558 - Flags: superreview?(jst)
Comment on attachment 220780 [details] [diff] [review]
Er, yes.  ;)

sr=jst
Attachment #220780 - Flags: superreview?(jst) → superreview+
Created attachment 221764 [details] [diff] [review]
With all parts really there
Attachment #220780 - Attachment is obsolete: true
Fixed.
Status: NEW → RESOLVED
Last Resolved: 11 years ago
Resolution: --- → FIXED
Blocks: 402995
Flags: blocking1.8.1.13+
Created attachment 308264 [details] [diff] [review]
1.8 branch version
Attachment #308264 - Flags: superreview?(bzbarsky)
Attachment #308264 - Flags: review?(bzbarsky)
Attachment #308264 - Flags: approval1.8.1.13?
Comment on attachment 308264 [details] [diff] [review]
1.8 branch version

Looks good. r+sr=bzbarsky
Attachment #308264 - Flags: superreview?(bzbarsky)
Attachment #308264 - Flags: superreview+
Attachment #308264 - Flags: review?(bzbarsky)
Attachment #308264 - Flags: review+
Comment on attachment 308264 [details] [diff] [review]
1.8 branch version

Approved for 1.8.1.13. a=ss
Attachment #308264 - Flags: approval1.8.1.13? → approval1.8.1.13+
Fix checked into 1.8 branch
Flags: blocking1.8.0.15?
Keywords: fixed1.8.1.13
qa: this can be tested with the test case in bug 402995
Flags: blocking1.8.0.15? → blocking1.8.0.15+
Attachment #308264 - Flags: approval1.8.0.15?
Comment on attachment 308264 [details] [diff] [review]
1.8 branch version

a=caillon for the 1.8.0 branch
Attachment #308264 - Flags: approval1.8.0.15? → approval1.8.0.15+
I verified bug 402995 using Firefox 2.0.0.12 on Ubuntu 7.10 with JRE 1.6.0_03-b05.
I then validated the fix for 402995 using Mozilla/5.0 (X11; U; Linux i686; en-US;
rv:1.8.1.13) Gecko/2008031115 Firefox/2.0.0.13, which is the RC1 for 2.0.0.13.
The bug no longer reproduces in either of the jar: versions. 

Marking as verified for 1.8.1.13
Keywords: fixed1.8.1.13 → verified1.8.1.13
MOZILLA_1_8_0_BRANCH:

Checking in caps/include/nsPrincipal.h;
/cvsroot/mozilla/caps/include/nsPrincipal.h,v  <--  nsPrincipal.h
new revision: 1.17.10.1; previous revision: 1.17
done
Checking in caps/src/nsPrincipal.cpp;
/cvsroot/mozilla/caps/src/nsPrincipal.cpp,v  <--  nsPrincipal.cpp
new revision: 1.37.2.1.2.2; previous revision: 1.37.2.1.2.1
done
Checking in caps/src/nsScriptSecurityManager.cpp;
/cvsroot/mozilla/caps/src/nsScriptSecurityManager.cpp,v  <--  nsScriptSecurityManager.cpp
new revision: 1.266.2.7.2.13; previous revision: 1.266.2.7.2.12
done
Keywords: fixed1.8.0.15
You need to log in before you can comment on or make changes to this bug.