336451 - nsSVGGeometryFrame::IsClipChild should check the namespace of the ancestor

Status: RESOLVED FIXED

(Core :: SVG, defect)

Description

[Jonathan Watt [:jwatt]]

Comment 1

[Jonathan Watt [:jwatt]]

Attachment: patch

Comment 2

[tor]

Comment on attachment 220664 [details] [diff] [review]
patch

>   do {
>-    if (node->Tag() == nsGkAtoms::clipPath) {
>+//  XXX: Do we want to abort if we find a non-svg ancestor? Are non-SVG
>+//  elements allowed inside an SVG clipPath element?
>+//  if (node->GetNameSpaceID() != kNameSpaceID_SVG) {
>+//    break;
>+//  }

I believe this section should be uncommented, and the comment adjusted.

With that change, r+sr=tor.

Comment 3

[Jonathan Watt [:jwatt]]

Attachment: patch checked in

Comment 4

[Jonathan Watt [:jwatt]]

Checked in.

Comment 5

[Mike Kaply [:mkaply]]

Jonathan,

What was the bug that was actually fixed here?

Comment 6

[Jonathan Watt [:jwatt]]

It's just a correctness issue to make sure we don't match <foo:clipPath> where foo is bound to a namespace other than the SVG namespace. Chances of someone throwing that in are negligable, but best to be correct. Risk is next to nothing.