Coverity oom crash [@ CERT_DecodeAuthKeyID]

RESOLVED FIXED in 3.11.2

Status

NSS
Libraries
P2
critical
RESOLVED FIXED
12 years ago
6 years ago

People

(Reporter: timeless, Assigned: Alexei Volkov)

Tracking

({coverity, crash})

3.11
3.11.2
All
Linux
coverity, crash

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [CID 304 710], crash signature, URL)

Attachments

(1 attachment, 1 obsolete attachment)

1.16 KB, patch
Nelson Bolyard (seldom reads bugmail)
: review+
Wan-Teh Chang
: review+
Details | Diff | Splinter Review
(Reporter)

Description

12 years ago
Description: Pointer "value" dereferenced before NULL check
(Reporter)

Comment 1

12 years ago
Created attachment 221174 [details] [diff] [review]
reorder null check
Assignee: nobody → timeless
Status: NEW → ASSIGNED
Attachment #221174 - Flags: review?(nelson)
Comment on attachment 221174 [details] [diff] [review]
reorder null check

Sorry, file changes that include lots of gratuitous tab->space conversion will not be acceptable.
Attachment #221174 - Flags: review?(nelson) → review-
Hardware: PC → All
Target Milestone: --- → 3.11.2
(Reporter)

Comment 3

12 years ago
that's fine. it's not my job to fix your bugs. i provide patches as a courtesy
Assignee: timeless → alexei.volkov.bugs
Status: ASSIGNED → NEW
Priority: -- → P2
(Assignee)

Comment 4

12 years ago
Created attachment 221852 [details] [diff] [review]
same, but less space->tab conversions
Attachment #221174 - Attachment is obsolete: true
Attachment #221852 - Flags: review?(nelson)
Comment on attachment 221852 [details] [diff] [review]
same, but less space->tab conversions

r=nelson
Attachment #221852 - Flags: review?(nelson) → review+
(Assignee)

Comment 6

12 years ago
truck
/cvsroot/mozilla/security/nss/lib/certdb/xauthkid.c,v  <--  xauthkid.c
new revision: 1.5; previous revision: 1.4
3.11 branch
/cvsroot/mozilla/security/nss/lib/certdb/xauthkid.c,v  <--  xauthkid.c
new revision: 1.4.28.1; previous revision: 1.4
Status: NEW → RESOLVED
Last Resolved: 12 years ago
Resolution: --- → FIXED

Updated

12 years ago
Attachment #221852 - Flags: review+
CID 710
Whiteboard: CID 710
Also CID 304
Whiteboard: CID 710 → [CID 304 710]

Updated

12 years ago
Summary: oom crash [@ CERT_DecodeAuthKeyID] → Coverity oom crash [@ CERT_DecodeAuthKeyID]
Crash Signature: [@ CERT_DecodeAuthKeyID]
You need to log in before you can comment on or make changes to this bug.