336479 - oomish crash [@ cryptojs_GetScriptPrincipal] because of a missing *

Status: RESOLVED FIXED

(Core Graveyard :: Security: UI, defect)

Description

[timeless]

I think this is probably an unreachable case, in which case the code should be optimized not to null check after it would crash.

Comment 1

[Boris Zbarsky [:bzbarsky]]

I assume the code meant to do:

   if (!*result) {

instead of what it does.  In any case, we should make that change.

Comment 2

[timeless]

Attachment: not quite what bz said

Comment 3

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 221178 [details] [diff] [review]
not quite what bz said

er.. no.  Wrong if statement.

Comment 4

[timeless]

Attachment: what bz said

Comment 5

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 221212 [details] [diff] [review]
what bz said

Yeah, better.  ;)

Comment 6

[Kai Engert [:KaiE:]]

Comment on attachment 221212 [details] [diff] [review]
what bz said

Good catch.

Comment 7

[Mike Connor [:mconnor]]

landed on trunk by timeless at the same time as he landed on the 1.8 branch.  Both branches were closed at the time, though apparently bsmedberg approved the trunk checkin.

Comment 8

[timeless]

mozilla/security/manager/ssl/src/nsCrypto.cpp	 1.65

MOZILLA_1_8_BRANCH:
mozilla/security/manager/ssl/src/nsCrypto.cpp	 1.55.2.7