336482 - Coverity crash or hopefully deadcode [@ crmf_copy_poposigningkey] because Pointer "destPopoSignKey" dereferenced before NULL check

Status: RESOLVED FIXED

(NSS :: Libraries, defect, P2)

Description

[timeless]

this looks like something that could be asserted, but at the very least, the null check in loser is pointless.

Comment 1

[Alexei Volkov]

Attachment: remove null check

Not a bug, us all callers of the functions check for NULL the destination pointer before copy data into it.

Non of the object copy functions check for incoming parameter before dereferencing them. This functionality should be implemented in a caller.

The patch removes unnecessary checks for NULL before structure destruction.

Comment 2

[Nelson Bolyard (seldom reads bugmail)]

Comment on attachment 221868 [details] [diff] [review]
remove null check

I have a feeling that someday we'll see these functions get called with NULL arguments, and someone will ask why the function doesn't check its arguments for NULL as the very first thing.  

But this patch is no less correct than before, and it should silence Coverity.  So 
r=nelson

Comment 3

[Alexei Volkov]

trunk
/cvsroot/mozilla/security/nss/lib/crmf/servget.c,v  <--  servget.c
new revision: 1.5; previous revision: 1.4

3.11 branch
/cvsroot/mozilla/security/nss/lib/crmf/servget.c,v  <--  servget.c
new revision: 1.3.28.2; previous revision: 1.3.28.1

Comment 4

[Nelson Bolyard (seldom reads bugmail)]

CID 631