Writing Spotlight metadata files for Bonjour bookmarks generates thousands of files

RESOLVED FIXED in Camino1.5

Status

P1
normal
RESOLVED FIXED
13 years ago
13 years ago

People

(Reporter: sfraser_bugs, Assigned: sfraser_bugs)

Tracking

({fixed1.8.0.4, fixed1.8.1, perf})

unspecified
Camino1.5
PowerPC
macOS
fixed1.8.0.4, fixed1.8.1, perf
Bug Flags:
camino1.0.2 +

Details

Attachments

(1 attachment)

(Assignee)

Description

13 years ago
I'm seeing thousands of files generated in my ~/Library/Caches/Metadata/Camino directory, which bogs down the entire machine as mds continually indexes them all. There are many more files than I have bookmarks.

This only happens when I'm on a network with a lot of Bonjour hosts.

I believe what's happening is that bookmarks are continually being created and destroyed as Bonjour hosts come and go. And since we don't delete metadata files when we delete bookmarks, they just pile up.

This also causes huge amounts of disk spinning when Camino starts up, since the first thing is does it delete all existing metadata files (which takes for-evar if there are thousands of them).

In addition, all the Bonjour changes seem to be causing Camino to needlessly re-save the bookmarks file every few seconds.
(Assignee)

Updated

13 years ago
Priority: -- → P1
If the performance hit is bad enough, do we want the fix for this in 1.0.2 as well?
OS: Mac OS X 10.3 → Mac OS X 10.4
See also bug 335163 for other issues with the way we (re)write bookmarks metadata for Spotlight.

(Also, adding Spotlight to the summary so this comes up in a Spotlight query)
Keywords: perf
Summary: Writing metadata files for Bonjour bookmarks generates thousandes of files → Writing Spotlight metadata files for Bonjour bookmarks generates thousandes of files
(Assignee)

Comment 3

13 years ago
I absolutely need a fix to be able to run Camino on a Bonjour-heavy network. I'll see if I can update a tree and work on a fix.
Assignee: nobody → sfraser_bugs
Summary: Writing Spotlight metadata files for Bonjour bookmarks generates thousandes of files → Writing Spotlight metadata files for Bonjour bookmarks generates thousands of files
I'm requesting this for 1.0.2 in the hopes Simon can get something out in the next few days so we can get 1.0.2 out in the next week. If not, we'll have to take this for 1.0.3.
Flags: camino1.0.2?
(Assignee)

Comment 5

13 years ago
This patch does N things:
1. Override writeBookmarksMetadataToPath/removeBookmarksMetadataFromPath in RendezvousBookmark to prevent metadata foo for such bookmarks.
2. Bails out of bookmarkChanged: when the item has no parent, or is in a smart folder, so that RendezvousBookmark changes don't cause bookmark file saving.
3. Deletes the contents of ~/Library/Caches/Metadata/Camino, rather than the directory itself (for bug 335163)
4. Add some autorelease pools for good measure.
5. Batches change notifications around the Bonjour folder rebuilding.
Attachment #220882 - Flags: review?(mikepinkerton)

Comment 6

13 years ago
Isn't creating and tearing down the autorelease pool on every iteration (instead of every 10-100) adding extra overhead?

Comment 7

13 years ago
Comment on attachment 220882 [details] [diff] [review]
Patch to disable metadata writing for Bonjour bookmarks

Hm, is your tree really old? 

I noticed in the BookmarkManager.mm diff that there's the newProfilePath method that I ripped out a few months ago.
(Assignee)

Comment 8

13 years ago
> Isn't creating and tearing down the autorelease pool on every iteration
> (instead of every 10-100) adding extra overhead?

Yeah, but trivial compared to the cost of deleting a file.

> Hm, is your tree really old? 

This is a patch against the 1.8.0 branch.
(Assignee)

Updated

13 years ago
Attachment #220882 - Flags: review?(mikepinkerton) → review?(mark)
Comment on attachment 220882 [details] [diff] [review]
Patch to disable metadata writing for Bonjour bookmarks

r=pink
Attachment #220882 - Flags: review?(mark) → review+
Plusing since we have a reviewed patch (and since it fixes the already-plused bug 335163); are we just waiting for trees to reopen so we can land on all 4 branches at once, or?
Blocks: 335163
Flags: camino1.0.2? → camino1.0.2+
(Assignee)

Comment 11

13 years ago
This is good to go; I just haven't had a chance to check it in. If someone would like to do the honours, then go for it.

Updated

13 years ago
Whiteboard: [needs checkin]

Comment 12

13 years ago
Checked in on trunk, MOZILLA_1_8_BRANCH (pre-1.8.1b1) and MOZILLA_1_8_0_BRANCH (1.8.0.4 for 1.0.2).
Status: NEW → RESOLVED
Last Resolved: 13 years ago
Keywords: fixed1.8.0.4, fixed1.8.1
Resolution: --- → FIXED
Whiteboard: [needs checkin]
You need to log in before you can comment on or make changes to this bug.