Closed Bug 336532 Opened 18 years ago Closed 18 years ago

Animated gif with transparency shows black background

Categories

(Core :: Graphics, defect)

x86
Windows XP
defect
Not set
normal

Tracking

()

RESOLVED FIXED

People

(Reporter: samuella, Assigned: bugz)

References

()

Details

(Keywords: regression)

Attachments

(4 files, 1 obsolete file)

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a1) Gecko/20060429 Minefield/3.0a1
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a1) Gecko/20060429 Minefield/3.0a1

If an animated gif is viewed that has been saved with a transparent layer, the background is shown as black.

Reproducible: Always

Steps to Reproduce:
1. open an animated gif like this one http://forum.cutaia.net/images/smiles/horse.gif
2. look at it

Actual Results:  
The background of some frames is black

Expected Results:  
The background should be transparent
Component: General → GFX: Thebes
Product: Firefox → Core
QA Contact: general → thebes
Version: unspecified → Trunk
Hmm, this was fixed as part of bug 324707 but seems to have regressed, see bug 324707 comment 20.
Status: UNCONFIRMED → NEW
Ever confirmed: true
Keywords: regression
Attached image testcase
the testcase works in IE/Opera/non-cairo and pre- bug 324707 cairo builds
I discovered this same problem as I was working on my theme. I worked around it by adding a white (non-transparent!) pixel in the lower right corner of every frame (I did this after adding an extra column that I hide afterwards).
This has a constant white pixel in the lower right corner as my work around.
*** Bug 341942 has been marked as a duplicate of this bug. ***
I also experience this on the latest build. 
Attached patch v1 (obsolete) — Splinter Review
This patch modifies SetMaskVisibility with rect version in way simmilar to patch from bug 324707.
Attachment #227587 - Flags: review?(vladimir)
Comment on attachment 227587 [details] [diff] [review]
v1

Bouncing this r? to stuart; he knows imglib better than I do.
Attachment #227587 - Flags: review?(vladimir) → review?(pavlov)
Attached patch v2Splinter Review
This patch additionaly fixes issues where some frames are shifted from original position (like http://img.photobucket.com/albums/v51/DaMoo/de2108f2.gif)
Attachment #227587 - Attachment is obsolete: true
Attachment #227632 - Flags: review?(pavlov)
Attachment #227587 - Flags: review?(pavlov)
When will the patch be applied to the latest trunk? I like to be beta testing Minefield, but it really bugs me, that animated gif's are shifted and in wrong colors :(
Comment on attachment 227632 [details] [diff] [review]
v2

dunno how i missed this
Attachment #227632 - Flags: review?(pavlov) → review+
Attachment #227632 - Flags: superreview?(roc)
Attachment #227632 - Flags: superreview?(roc) → superreview+
Status: NEW → ASSIGNED
Whiteboard: [checkin needed]
Assignee: nobody → prefiks
Status: ASSIGNED → NEW
mozilla/gfx/src/thebes/nsThebesRenderingContext.cpp 	1.30
mozilla/modules/libpr0n/decoders/gif/imgContainerGIF.cpp 	1.28
Status: NEW → RESOLVED
Closed: 18 years ago
Resolution: --- → FIXED
Whiteboard: [checkin needed]
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: