33656 - nsZipItem destructor crash in Mac XPInstall engine runnig from the stub

Status: VERIFIED FIXED

(SeaMonkey :: Installer, defect, P1)

Description

[shrirang khanzode]

I see a crash midway during installation when I use the installer for mac trunk 
build for today. Trying to start seamonkey hangs my machine.

Comment 1

[shrirang khanzode]

laurel, Esther said that you saw a crash when you used the mac installer today. 
Could you please give your system details ? Thanks !

Comment 2

[Samir Gehani]

This is an XPInstall engine bug.

Jimmy, 
Could you verify this from the browser: any .xpi installation should crash?  
Attach a stack crawl if possible.  Thanks.

Comment 3

[Samir Gehani]

Attachment: Stack crawl of XPInstall engine crash when used from the Mac Install Wizard.

Comment 4

[Samir Gehani]

The XPInstall engine crashes in UI code destruction when run from the browser 
(totally separate the crash identified by Shrirang for which we have teh 
atatched stack trace).  Investigating in the Mac Install Wizard context further.

Comment 5

[Samir Gehani]

I'm sure this'll interest jj too so I'm cc'ing him :o)

Comment 6

[Jon Granrose]

marking smoketest blocker.

Comment 7

[Jimmy Lee]

Attachment: Crash on second trigger of jar/xpi file.

Comment 8

[Jimmy Lee]

Build: 2000-03-28-08-M15(MAC)

Instead of installing, I unzipped Netscape6-mac.sea.bin and was successful with 
launching the browser.  From http://jimbob/trigger2.html, I was able to 
successfully trigger a_adddelcomp from the drop-down menu.  When I triggered a 
second archive, a_adddirectory_5_string_ver, I crashed into MacsBug (
Created an attachment (id=7063)

Comment 9

[Cathleen]

samir will take a look at this again today.

Comment 10

[Samir Gehani]

Jimmy,
Your crash is different than this bug.  Please file a seperate bug with the 
stack.  Thanks.

Comment 11

[Jon Granrose]

talking with samir, it will take a while to get this fixed, and having the tree 
open shouldn't impact him, so I'm opening the tree.

Comment 12

[Samir Gehani]

Fix checked in.  I think this may also fix the XPInstall mac horkage.  

Comment 13

[Grace Bush]

verified in 2000-03-30-08M15 build

Comment 14

[Karen Huang]

Used Mac 2000-03-30-08M15 commercial build
It still crashs for my G4 machine after finish the first installation processing 
for Navigator when processing 917 files......
Will attach the MacsBug report.

Comment 15

[Karen Huang]

Attachment: macsbug report for today's mac installer

Comment 16

[Samir Gehani]

Huang,
This is the old problem where you have to clean out your Temporary Items folder 
or you'll get an old (and broken) .xpi.  I'll stop by.

This appears to be becoming more rampant so I'll plan on taking the smarts out 
of the download process with SmartDownload out for M15 rather than later.

Comment 17

[Karen Huang]

It's working now after sgehani clean out my Temporary Items folder.