336605 - Crash going offline and visiting other url (using window.close on offline event handler)

Status: RESOLVED FIXED

(Core :: DOM: UI Events & Focus Handling, defect)

Description

[Martijn Wargers (dead)]

See upcoming testcase, which crashes current trunk Mozilla build when following the steps in the testcase.

- Click on the button in the testcase to open a new window.
- Go offline by selecting that option in the File menu
(after you've done that, this window should have disappeared)
- Now visit another url by clicking on one of your bookmarks

Result: crash

Talkback ID: TB18290268M
PresShell::InitialReflow   nsContentSink::StartLayout   0x024d7244

Comment 1

[Martijn Wargers (dead)]

Attachment: testcase

Comment 2

[Robert O'Callahan (:roc) (email my personal email if necessary)]

(In reply to comment #0)
> - Click on the button in the testcase to open a new window.
> - Go offline by selecting that option in the File menu
> (after you've done that, this window should have disappeared)

For me, this step doesn't close the window until I click on the window (separate bug that I've already tracked down, not mine I think...), and then it doesn't crash. Let me fix this other bug first.

Comment 3

[Robert O'Callahan (:roc) (email my personal email if necessary)]

With the patch for 336674, the window closes on time, but I still don't crash. Martijn, can you get me a better stack with gdb?

Comment 4

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Preferably after applying the patch in bug 336674.

Comment 5

[Martijn Wargers (dead)]

(In reply to comment #2)
> For me, this step doesn't close the window until I click on the window
> (separate bug that I've already tracked down, not mine I think...), and then it
> doesn't crash. Let me fix this other bug first.

Sorry, I wasn't clear enough, that's what I meant. The window should have disappeared, but that doesn't happen in current trunk builds. So when that is fixed, the crash bug is also fixed. So nothing to worry about after that.

Comment 6

[Justin Wood (:Callek)]

Martijn, given that Bug 336674 landed, is this bug still applicable?

Comment 7

[Martijn Wargers (dead)]

(In reply to comment #6)
> Martijn, given that Bug 336674 landed, is this bug still applicable?

No, I guess I forgot about this bug, thanks. This works fine now.