Closed Bug 336617 Opened 20 years ago Closed 20 years ago

Caret is placed in the middle of the line when pressing "Home" in line beginning with reverse-direction text

Categories

(Core :: Layout: Text and Fonts, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla1.9alpha1

People

(Reporter: nir123, Assigned: uriber)

References

Details

(Keywords: regression, testcase)

Attachments

(2 files)

User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a1) Gecko/20060503 Minefield/3.0a1 Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a1) Gecko/20060503 Minefield/3.0a1 Follow the instructions in the upcoming testcase. Reproducible: Always
Attached file testcase
Keywords: regression, testcase
Regression range is between 2006-04-25 and 2006-04-26, likely due to bug 330305.
Blocks: 330305
Status: UNCONFIRMED → NEW
Component: Layout → Layout: BiDi Hebrew & Arabic
Ever confirmed: true
OS: Windows XP → All
Hardware: PC → All
Summary: Caret is placed in the middle of the line when pressing "Home" in textarea which contains Hebrew and English. → Caret is placed in the middle of the line when pressing "Home" in line beginning with reverse-direction text
Attached patch patchSplinter Review
These two got mixed up.
Assignee: nobody → uriber
Status: NEW → ASSIGNED
Attachment #220795 - Flags: superreview?(roc)
Attachment #220795 - Flags: review?
Attachment #220795 - Flags: review? → review?(marcldl+mozbugs)
Actually, was that change (using a struct) really necessary? I find it less readable this way, and more prone to errors (as this bug demonstrates).
Attachment #220795 - Flags: superreview?(roc)
Attachment #220795 - Flags: superreview+
Attachment #220795 - Flags: review?(marcldl+mozbugs)
Attachment #220795 - Flags: review+
We could break SetData up into separate setter methods if that's a concern.
Checked in: Checking in layout/generic/nsSelection.cpp;/cvsroot/mozilla/layout/generic/nsSelection.cpp,v <-- nsSelection.cppnew revision: 3.236; previous revision: 3.235 done
Status: ASSIGNED → RESOLVED
Closed: 20 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9alpha
Component: Layout: BiDi Hebrew & Arabic → Layout: Text
QA Contact: layout → layout.fonts-and-text
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: