336726 - XUL: Non-relevant controls should not be shown

Status: RESOLVED FIXED

(Core Graveyard :: XForms, defect)

Description

[Allan Beaufour]

Controls bound to non-relevant nodes should not be shown per default (like for XHTML).

Comment 1

[Allan Beaufour]

Attachment: Testcase

Comment 2

[alexander :surkov (:asurkov)]

Attachment: patch

It's pretty simple patch but I don't like a lot !important flag. The problem is style for :disabled is applied before other styles. !important solves the problem but is it right?

Comment 3

[Allan Beaufour]

Comment on attachment 221041 [details] [diff] [review]
patch

(In reply to comment #2)
> Created an attachment (id=221041) [edit]
> patch
> 
> It's pretty simple patch but I don't like a lot !important flag. The problem is
> style for :disabled is applied before other styles. !important solves the
> problem but is it right?

No, because then it cannot be overriden by the form author.

Comment 4

[alexander :surkov (:asurkov)]

(In reply to comment #3)
> (From update of attachment 221041 [details] [diff] [review] [edit])
> (In reply to comment #2)
> > Created an attachment (id=221041) [edit]
> > patch
> > 
> > It's pretty simple patch but I don't like a lot !important flag. The problem is
> > style for :disabled is applied before other styles. !important solves the
> > problem but is it right?
> 
> No, because then it cannot be overriden by the form author.
> 

Not quite, it can override by using '!important' flag :)

How about the such approach?

Comment 5

[alexander :surkov (:asurkov)]

Attachment: patch2

Comment 6

[Allan Beaufour]

(In reply to comment #4)
> (In reply to comment #3)
> > (From update of attachment 221041 [details] [diff] [review] [edit] [edit])
> > (In reply to comment #2)
> > > Created an attachment (id=221041) [edit]
> > > patch
> > > 
> > > It's pretty simple patch but I don't like a lot !important flag. The problem is
> > > style for :disabled is applied before other styles. !important solves the
> > > problem but is it right?
> > 
> > No, because then it cannot be overriden by the form author.
> > 
> 
> Not quite, it can override by using '!important' flag :)

No, because I tbelieve that our agent style sheet is a "user stylesheet":
"Both author and user style sheets may contain "!important" declarations, and user "!important" rules override author "!important" rules."
[http://www.w3.org/TR/REC-CSS2/cascade.html#important-rules]

Comment 7

[Allan Beaufour]

Comment on attachment 221560 [details] [diff] [review]
patch2

I'm not sure I like the approach, but it's css styling. Off we go :)

r=me

Comment 8

[Allan Beaufour]

Fixed on trunk