Closed Bug 336932 Opened 15 years ago Closed 15 years ago

Coverity 163, dead code in mozilla/security/nss/lib/ssl/ssl3con.c

Categories

(NSS :: Libraries, defect, P3)

3.11
All
Linux
defect

Tracking

(Not tracked)

RESOLVED FIXED
3.11.2

People

(Reporter: jonsmirl, Assigned: alvolkov.bgs)

Details

(Keywords: coverity, Whiteboard: [CID 163 855])

Attachments

(1 file, 1 obsolete file)

Coverity is correct it is impossible to get to this case. An IF checks for it before entering the switch. The goto path can't get to it either.

diff -r1.76 ssl3con.c
7599,7601d7598
<     case content_application_data:
<       rv = SECSuccess;
<       break;
Attached patch Remove dead code (obsolete) — Splinter Review
Hardware: PC → All
Target Milestone: --- → 3.11.2
Version: unspecified → 3.11
Severity: normal → trivial
Priority: -- → P3
Attachment #221120 - Flags: review?(wtchang)
Attachment #221120 - Attachment is obsolete: true
Attachment #221770 - Flags: review?(wtchang)
Attachment #221120 - Flags: review?(wtchang)
Comment on attachment 221770 [details] [diff] [review]
Unified diff, patch is the same

r=nelson
This code should be replaced with a comment explaingin that this case is handled before the switch.
Attachment #221770 - Flags: review?(wtchang) → review+
trunk
/cvsroot/mozilla/security/nss/lib/ssl/ssl3con.c,v  <--  ssl3con.c
new revision: 1.89; previous revision: 1.88
3.11 branch
/cvsroot/mozilla/security/nss/lib/ssl/ssl3con.c,v  <--  ssl3con.c
new revision: 1.76.2.11; previous revision: 1.76.2.10
Status: NEW → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
Assignee: nobody → alexei.volkov.bugs
CID 163 and 855
Whiteboard: [CID 163 855]
You need to log in before you can comment on or make changes to this bug.