336932 - Coverity 163, dead code in mozilla/security/nss/lib/ssl/ssl3con.c

Status: RESOLVED FIXED

(NSS :: Libraries, defect, P3)

Description

[Jon Smirl]

Coverity is correct it is impossible to get to this case. An IF checks for it before entering the switch. The goto path can't get to it either.

diff -r1.76 ssl3con.c
7599,7601d7598
<     case content_application_data:
<       rv = SECSuccess;
<       break;

Comment 1

[Jon Smirl]

Attachment: Remove dead code

Comment 2

[Jon Smirl]

Attachment: Unified diff, patch is the same

Comment 3

[Nelson Bolyard (seldom reads bugmail)]

Comment on attachment 221770 [details] [diff] [review]
Unified diff, patch is the same

r=nelson
This code should be replaced with a comment explaingin that this case is handled before the switch.

Comment 4

[Alexei Volkov]

trunk
/cvsroot/mozilla/security/nss/lib/ssl/ssl3con.c,v  <--  ssl3con.c
new revision: 1.89; previous revision: 1.88
3.11 branch
/cvsroot/mozilla/security/nss/lib/ssl/ssl3con.c,v  <--  ssl3con.c
new revision: 1.76.2.11; previous revision: 1.76.2.10

Comment 5

[Nelson Bolyard (seldom reads bugmail)]

CID 163 and 855