Closed
Bug 336934
Opened 20 years ago
Closed 20 years ago
Coverity 173, dead code in mozilla/security/nss/lib/softoken/pkcs11c.c
Categories
(NSS :: Libraries, defect, P3)
Tracking
(Not tracked)
RESOLVED
FIXED
3.11.2
People
(Reporter: jonsmirl, Assigned: wtc)
Details
(Keywords: coverity)
Attachments
(1 file, 1 obsolete file)
|
761 bytes,
patch
|
nelson
:
review+
|
Details | Diff | Splinter Review |
The variable ck_id is not used and can be removed.
diff -r1.68 pkcs11c.c
3992d3991
< SECItem *ck_id = NULL;
4200,4203d4198
< if(ck_id) {
< SECITEM_ZfreeItem(ck_id, PR_TRUE);
< }
<
|
||
Updated•20 years ago
|
Hardware: PC → All
Target Milestone: --- → 3.11.2
Version: unspecified → 3.11
|
|
||
Updated•20 years ago
|
Severity: normal → trivial
Priority: -- → P3
Attachment #221122 -
Flags: review?(wtchang)
Attachment #221122 -
Attachment is obsolete: true
Attachment #221769 -
Flags: review?(wtchang)
Attachment #221122 -
Flags: review?(wtchang)
|
|
||
Comment 3•20 years ago
|
||
Comment on attachment 221769 [details] [diff] [review]
Unified diff, patch is the same
r=nelson
Wtchang is on another project right now, so in the interest of expedience, please ask me or alexei.volkov.bugs for reviews.
Attachment #221769 -
Flags: review?(wtchang) → review+
|
Assignee | |
Comment 4•20 years ago
|
||
I checked in the patch on the NSS trunk (NSS 3.12) and
NSS_3_11_BRANCH (NSS 3.11.2).
Status: NEW → RESOLVED
Closed: 20 years ago
Resolution: --- → FIXED
|
|
||
Updated•20 years ago
|
Assignee: nobody → wtchang
You need to log in
before you can comment on or make changes to this bug.
Description
•