336937 - Coverity 171, dead code in mozilla/security/nss/lib/softoken/pcertdb.c

Status: RESOLVED FIXED

(NSS :: Libraries, defect, P3)

Description

[Jon Smirl]

AddNicknameToSubject()
{
// check for NUll is done at top of routine
    if ( nickname == NULL ) {
	return(SECFailure);
    }

This later check is not needed since the variable does not get changed

diff -r1.53 pcertdb.c
2797,2798c2797
<     entry->nickname = (nickname) ?
<                       PORT_ArenaStrdup(entry->common.arena, nickname) : NULL;
---
>     entry->nickname = PORT_ArenaStrdup(entry->common.arena, nickname);

Comment 1

[Jon Smirl]

Attachment: Remove dead code

Comment 2

[Jon Smirl]

Attachment: Unified diff, patch is the same

Comment 3

[Nelson Bolyard (seldom reads bugmail)]

Comment on attachment 221766 [details] [diff] [review]
Unified diff, patch is the same

r=nelson

Comment 4

[Wan-Teh Chang]

I checked in the patch on the NSS trunk (NSS 3.12) and
NSS_3_11_BRANCH (NSS 3.11.2).