336939 - Extension manager passes bogus URIs to ConvertChromeURL

Status: RESOLVED FIXED

(Toolkit :: Add-ons Manager, defect)

Description

[Boris Zbarsky [:bzbarsky]]

BUILD:  Current Firefox trunk build

STEPS TO REPRODUCE:
1)  Load https://addons.mozilla.org/firefox/1865/
2)  Install the extension

ACTUAL RESULTS:

###!!! ASSERTION: Non-chrome URI?: 'isChrome', file ../../../mozilla/chrome/src/nsChromeRegistry.cpp, line 608

EXPECTED RESULTS: No asserts.

The URI in question is https://addons.mozilla.org/images/default.png

The call to ConvertChromeURL comes from an anonymous function on line 7485 of the post-preprocessing nsExtensionManager.js.  That would seem to be http://bonsai.mozilla.org/cvsblame.cgi?file=mozilla/toolkit/mozapps/extensions/src/nsExtensionManager.js.in&rev=1.193&mark=7656#7656

Comment 1

[Robert Strong (they/them - no direct email)]

I believe the patch that added the code that causes the assertion was introduced in bug 286034 and not bug 329045

Comment 2

[Robert Strong (they/them - no direct email)]

Attachment: Remove ConvertChromeURL

Also prevents the use of schemes other than chrome or http and https when the item is installing.

Comment 3

[Robert Strong (they/them - no direct email)]

Attachment: missed enclosing paren in last patch

Comment 4

[Robert Strong (they/them - no direct email)]

Fixed on trunk