336947 - Maximum width of location bar/search field is fixed at 2560 pixels

Status: RESOLVED FIXED

(Camino Graveyard :: Toolbars & Menus, defect)

Description

[Chris Lawson (gone)]

We should measure the width of all available displays and use that instead of hard-coding a max width value. The relevant code is on line 1238 of BrowserWindowController.mm.

Comment 1

[Wevah (Nate Weaver)]

We should hard-code it, but it should be set to some insanely huge number (which I think was the intention). Maybe something like FLT_MAX.

Comment 2

[froodian (Ian Leue)]

Attachment: Patch to make max FLT_MAX

OK.  Since I still can't build (can't reinstall OS X until school is over), I haven't tested this, so uploading a patch may be a no-no in this situation, but it's so ridonkulous that I couldn't resist just doing it.  If this was notcool of me, somebody else can feel free to take this, and sorry for the bug/patchspam. :p

Comment 3

[Chris Lawson (gone)]

Comment on attachment 221201 [details] [diff] [review]
Patch to make max FLT_MAX

r,sr,a=me :-p

Seriously, though, r=me, pending a statement from pink or smfr why we chose 2560 in the first place.

cl

Comment 4

[Chris Lawson (gone)]

Comment on attachment 221201 [details] [diff] [review]
Patch to make max FLT_MAX

Oops. Forgot to set the flag.

Oh, and it's "redonkulous". The "e" is important.

cl

Comment 5

[froodian (Ian Leue)]

Comment on attachment 221201 [details] [diff] [review]
Patch to make max FLT_MAX

Mike, can you sr this?  Assuming that your original intention for the max was indeed just to be 'wicked big', all it'll need is a thumbs-up.

Comment 6

[Stuart Morgan]

That value is from hyatt's original BWC code, so the reason for that particular magic number may forever remain a mystery.

Comment 7

[Chris Lawson (gone)]

Well, 2560 jumped out at me as the max resolution of a Cinema Display, which is probably where it came from, but methinks Hyatt must've figured no one would ever have a browser window big enough to span two of them ;)

cl

Comment 8

[Mike Pinkerton (not reading bugmail)]

Comment on attachment 221201 [details] [diff] [review]
Patch to make max FLT_MAX

sr=pink

Comment 9

[Håkan Waara]

Checked in.