Closed Bug 336964 Opened 14 years ago Closed 13 years ago

Useless null check of aUri in txMozillaXSLTProcessor::LoadStyleSheet

Categories

(Core :: XSLT, defect, trivial)

x86
Windows XP
defect
Not set
trivial

Tracking

()

RESOLVED FIXED

People

(Reporter: timeless, Assigned: timeless)

References

(Blocks 1 open bug, )

Details

(Keywords: coverity)

Attachments

(1 obsolete file)

 
We should remove the nullcheck. There is no point in calling that function with a null aURI.
Severity: critical → trivial
Keywords: crash
Summary: crash [@ txMozillaXSLTProcessor::LoadStyleSheet] "aUri" Pointer dereferenced before NULL check → Useless null check of aUri in txMozillaXSLTProcessor::LoadStyleSheet
Attached patch remove useless null check (obsolete) — Splinter Review
Assignee: xslt → timeless
Status: NEW → ASSIGNED
Attachment #221180 - Flags: superreview?(bzbarsky)
Attachment #221180 - Flags: review?(bugmail)
Attachment #221180 - Flags: superreview?(bzbarsky) → superreview+
Comment on attachment 221180 [details] [diff] [review]
remove useless null check

mozilla/content/xslt/src/xslt/txMozillaXSLTProcessor.cpp 	1.51
Attachment #221180 - Attachment is obsolete: true
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.