336966 - Useless null check of shell in nsXIEngine::DeleteXPIs

Status: RESOLVED FIXED

(Core Graveyard :: Installer: XPInstall Engine, defect)

Description

[timeless]

the caller that matters is careful:
http://bonsai.mozilla.org/cvsblame.cgi?file=mozilla/toolkit/mozapps/installer/unix/wizard/nsInstallDlg.cpp&rev=1.3&mark=598-602,650#597

since this is a fairly internal function there's no point in including the null check.

Comment 1

[Ryan Jones-Ward [:sciguyryan]]

Attachment: Patch v1

First try at a patch, removing the null check |if (!aComps || !mOriginalDir)| and its return.

Comment 2

[Benjamin Smedberg]

Comment on attachment 239396 [details] [diff] [review]
Patch v1

Since only seamonkey uses the linux installer (and I think even that's moving away), I'm not reviewing patches for that any more. Let's try CTho.

Comment 3

[Chris Thomas (CTho) [formerly [e-mail] [e-mail]]]

Comment on attachment 239396 [details] [diff] [review]
Patch v1

Sorry, I don't build on platforms that use this file, and I wouldn't know how to test that it doesn't break anything either.

Comment 4

[Andrew Schultz]

FIXED