Closed Bug 336982 Opened 15 years ago Closed 15 years ago

Useless null check of ss in ssl3_config_match_init

Categories

(NSS :: Libraries, defect, P3)

3.11
All
Linux
defect

Tracking

(Not tracked)

RESOLVED FIXED
3.11.2

People

(Reporter: timeless, Assigned: nelson)

References

()

Details

(Keywords: coverity, Whiteboard: [CID 441])

Attachments

(1 file, 1 obsolete file)

 
Attached patch remove useless null check (obsolete) — Splinter Review
Assignee: nobody → timeless
Status: NEW → ASSIGNED
Attachment #221189 - Flags: review?(nelson)
Comment on attachment 221189 [details] [diff] [review]
remove useless null check

Clearly the !ss check is useless where it is.  
But rather than eliminating it, it should be moved up to the
beginning of the function where it would be useful.  
An assertion wouldn't hurt, either.
Attachment #221189 - Flags: review?(nelson) → review-
Hardware: PC → All
Target Milestone: --- → 3.11.2
Priority: -- → P3
taking.
Assignee: timeless → nelson
Status: ASSIGNED → NEW
Alexei, please review.  Ensure that the new ss test avoids the crash.
Attachment #221189 - Attachment is obsolete: true
Attachment #222460 - Flags: review?(alexei.volkov.bugs)
Comment on attachment 222460 [details] [diff] [review]
Detect null "ss" in time to prevent a crash

r=alexei.volkov.bugs
Attachment #222460 - Flags: review?(alexei.volkov.bugs) → review+
Checking in ssl/ssl3con.c; new revision: 1.90; previous revision: 1.89
Checking in ssl3con.c; new revision: 1.76.2.12; previous revision: 1.76.2.11
Status: NEW → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
CID 441
Whiteboard: [CID 441]
You need to log in before you can comment on or make changes to this bug.