Closed
Bug 336982
Opened 19 years ago
Closed 19 years ago
Useless null check of ss in ssl3_config_match_init
Categories
(NSS :: Libraries, defect, P3)
Tracking
(Not tracked)
RESOLVED
FIXED
3.11.2
People
(Reporter: timeless, Assigned: nelson)
References
()
Details
(Keywords: coverity, Whiteboard: [CID 441])
Attachments
(1 file, 1 obsolete file)
|
927 bytes,
patch
|
alvolkov.bgs
:
review+
|
Details | Diff | Splinter Review |
|
Assignee | |
Comment 2•19 years ago
|
||
Comment on attachment 221189 [details] [diff] [review]
remove useless null check
Clearly the !ss check is useless where it is.
But rather than eliminating it, it should be moved up to the
beginning of the function where it would be useful.
An assertion wouldn't hurt, either.
Attachment #221189 -
Flags: review?(nelson) → review-
|
|
Assignee | |
Updated•19 years ago
|
Hardware: PC → All
Target Milestone: --- → 3.11.2
|
|
Assignee | |
Updated•19 years ago
|
Priority: -- → P3
|
|
Assignee | |
Comment 4•19 years ago
|
||
Alexei, please review. Ensure that the new ss test avoids the crash.
Attachment #221189 -
Attachment is obsolete: true
Attachment #222460 -
Flags: review?(alexei.volkov.bugs)
|
||
Comment 5•19 years ago
|
||
Comment on attachment 222460 [details] [diff] [review]
Detect null "ss" in time to prevent a crash
r=alexei.volkov.bugs
Attachment #222460 -
Flags: review?(alexei.volkov.bugs) → review+
|
|
Assignee | |
Comment 6•19 years ago
|
||
Checking in ssl/ssl3con.c; new revision: 1.90; previous revision: 1.89
Checking in ssl3con.c; new revision: 1.76.2.12; previous revision: 1.76.2.11
Status: NEW → RESOLVED
Closed: 19 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•