337009 - Coverity OOM crash [@ nssList_Count - nssTrustDomain_GetCertsFromCache] Dereferencing possibly NULL "certList"

Status: RESOLVED FIXED

(NSS :: Libraries, defect, P2)

Description

[timeless]

Event returned_null: Function "nssList_Create" returned NULL value (checked 15 out of 17 times)

Comment 1

[Alexei Volkov]

Attachment: return null if could not create an empty list

this part of the code if never used(according to lxr). May be this is something
that need to be removed.

Comment 2

[Nelson Bolyard (seldom reads bugmail)]

(In reply to comment #1)
> this part of the code if never used(according to lxr). 
> May be this is something that need to be removed.

Are you saying that nssTrustDomain_GetCertsFromCache is never called?
(Appears to me that it is)
Or are you saying that all callers always provde a non-NULL certListOpt?

Comment 3

[Nelson Bolyard (seldom reads bugmail)]

Comment on attachment 222395 [details] [diff] [review]
return null if could not create an empty list

r=nelson

Comment 4

[Alexei Volkov]

It is called at least four times, but all the callers provide already created certListOpt

Comment 5

[Alexei Volkov]

trunk:
/cvsroot/mozilla/security/nss/lib/pki/tdcache.c,v  <--  tdcache.c
new revision: 1.43; previous revision: 1.42

3.11 branch:
/cvsroot/mozilla/security/nss/lib/pki/tdcache.c,v  <--  tdcache.c
new revision: 1.42.2.1; previous revision: 1.42

Comment 6

[Nelson Bolyard (seldom reads bugmail)]

CID 294