Closed
Bug 337044
Opened 19 years ago
Closed 19 years ago
Search engine Manager leaks an observer when canceled
Categories
(Firefox :: Search, defect)
Tracking
()
VERIFIED
FIXED
Firefox 2 alpha3
People
(Reporter: regis.caspar+bz, Assigned: regis.caspar+bz)
Details
(Keywords: fixed1.8.1, memory-leak)
Attachments
(1 file)
|
1.46 KB,
patch
|
Gavin
:
review+
mconnor
:
approval-branch-1.8.1+
|
Details | Diff | Splinter Review |
User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a1) Gecko/20060507 Minefield/3.0a1
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a1) Gecko/20060507 Minefield/3.0a1
The new search engine manager leaks an observer when canceled.
Reproducible: Always
Steps to Reproduce:
1. Open Search Engine Manager
2. Click Cancel
Actual Results:
An observer is leaked
Expected Results:
No leak
|
Assignee | |
Comment 1•19 years ago
|
||
This patch add a onCancel function which remove the leaked observer
Attachment #221226 -
Flags: review?
Confirming with dbarons leak detection extension
Status: UNCONFIRMED → NEW
Ever confirmed: true
|
||
Comment 3•19 years ago
|
||
Eek, good catch!
Assignee: nobody → regis.caspar+bz
OS: Windows XP → All
Hardware: PC → All
Target Milestone: --- → Firefox 2 beta1
|
|
||
Updated•19 years ago
|
Status: NEW → ASSIGNED
Summary: [mlk] Search engine Manager leaks an observer when canceled → Search engine Manager leaks an observer when canceled
Version: unspecified → 2.0 Branch
|
|
||
Comment 4•19 years ago
|
||
Comment on attachment 221226 [details] [diff] [review]
Fix by adding a onCancel function
This doesn't need to land before the alpha, but marking a181? so I don't forget it.
Attachment #221226 -
Flags: review?
Attachment #221226 -
Flags: review+
Attachment #221226 -
Flags: approval-branch-1.8.1?(mconnor)
|
|
Assignee | |
Comment 5•19 years ago
|
||
(In reply to comment #3)
> Eek, good catch!
All merits goes to David Baron and his leaks monitor extension :)
|
||
Updated•19 years ago
|
Attachment #221226 -
Flags: approval-branch-1.8.1?(mconnor) → approval-branch-1.8.1+
|
|
||
Comment 6•19 years ago
|
||
mozilla/browser/components/search/content/engineManager.xul 1.2
mozilla/browser/components/search/content/engineManager.js 1.2
Status: ASSIGNED → RESOLVED
Closed: 19 years ago
Resolution: --- → FIXED
Whiteboard: [checkin needed (1.8 branch)]
|
|
Assignee | |
Comment 7•19 years ago
|
||
(In reply to comment #6)
> mozilla/browser/components/search/content/engineManager.xul 1.2
> mozilla/browser/components/search/content/engineManager.js 1.2
Verified fixed on Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a1) Gecko/20060513 Minefield/3.0a1 ID:2006051304 [cairo]
|
|
Assignee | |
Comment 9•19 years ago
|
||
(In reply to comment #8)
> Thanks for the patch, Regis!
No problem :)
|
|
||
Comment 10•19 years ago
|
||
mozilla/browser/components/search/content/engineManager.xul 1.1.2.3
mozilla/browser/components/search/content/engineManager.js 1.1.2.3
Keywords: fixed1.8.1
Whiteboard: [checkin needed (1.8 branch)]
Target Milestone: Firefox 2 beta1 → Firefox 2 alpha3
You need to log in
before you can comment on or make changes to this bug.
Description
•