Closed Bug 337079 Opened 18 years ago Closed 18 years ago

Add-Ons manager scrolls when window gets focus

Categories

(Toolkit :: Add-ons Manager, defect)

x86
Linux
defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla1.8.1beta1

People

(Reporter: bzbarsky, Assigned: mwu)

References

Details

(Keywords: fixed1.8.1, Whiteboard: [SWAG: 0d])

Attachments

(1 file, 2 obsolete files)

BUILD:  Current trunk Firefox build

STEPS TO REPRODUCE:
1)  Start with a vanilla profile
2)  Install enough extensions that in the Add-On manager there are a few out of 
    sight below the bottom of the window.  I have Adblock Plus, DOM Inspector,
    Google Safe Browsing, Leak Monitor, XForms, Nightly Tester Tools, Web
    Developer.
3)  Scroll down all the way to the bottom of the list.
4)  Select the last item.
5)  Scroll all the way to the top of the list by dragging the scrollbar slider
    (so that the last item remains selected.
6)  Switch focus to a different window (in my case, just hover it; on Windows or
    Mac click a title bar, etc).
7)  Switch focus back to the Add-Ons Manager

ACTUAL RESULTS:  The Add-Ons Manager scrolls all the way down

EXPECTED RESULTS:  Stay scrolled to where I put it in step 5.
Flags: blocking1.9a2?
Flags: blocking-firefox2?
Please try duplicating this with the download mgr... I suspect you are able to and this is an Toolkit XUL Widget bug that is not due to bug 329045 and has been present on the trunk since bug 328881 was checked in.
This one I can duplicate on the 1.8 branch and trunk and it doesn't affect the download mgr.
Flags: blocking-firefox2? → blocking-firefox2+
Assignee: nobody → michael.wu
Target Milestone: --- → Firefox 2 beta1
Comment on attachment 224278 [details] [diff] [review]
Prevent scrolling of list upon focus if not a new selection.

This is against MOZILLA_1_8_BRANCH. It makes the behavior of the richlistbox in the addons manager consistent with other richlistboxes in firefox such as the error console and the downloads dialog.
Attachment #224278 - Flags: review?(robert.bugzilla)
Whiteboard: [SWAG: 0d]
This patch eliminates whitespace issues, memory leaks, and other badness from the previous patch. But otherwise, does the same thing.
Attachment #224278 - Attachment is obsolete: true
Attachment #224453 - Flags: review?(robert.bugzilla)
Attachment #224278 - Flags: review?(robert.bugzilla)
Does the same thing as before, except this takes advantage of an already existing last-selection attribute maintained by richlistbox.
Attachment #224453 - Attachment is obsolete: true
Attachment #224457 - Flags: review?(robert.bugzilla)
Attachment #224453 - Flags: review?(robert.bugzilla)
Comment on attachment 224457 [details] [diff] [review]
Prevent scrolling of list upon focus if not a new selection.

Looks good and thanks!
Attachment #224457 - Flags: review?(robert.bugzilla) → review+
Comment on attachment 224457 [details] [diff] [review]
Prevent scrolling of list upon focus if not a new selection.

I'm also comfortable with landing this on 1.8.1.
Attachment #224457 - Flags: approval-branch-1.8.1+
Checked in to trunk and MOZILLA_1_8_BRANCH
Status: NEW → RESOLVED
Closed: 18 years ago
Flags: blocking1.9a2?
Keywords: fixed1.8.1
Resolution: --- → FIXED
Product: Firefox → Toolkit
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: