Coverity 446, dead code in mozilla/security/nss/lib/certhigh/ocsp.c

RESOLVED FIXED in 3.11.2

Status

NSS
Libraries
P3
trivial
RESOLVED FIXED
12 years ago
12 years ago

People

(Reporter: Jon Smirl, Assigned: Alexei Volkov)

Tracking

({coverity})

3.11
3.11.2
coverity

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [CID 446 843])

Attachments

(1 attachment)

(Reporter)

Description

12 years ago
it is not possible for statusContext to be null in the error case

@@ -3764,8 +3764,6 @@
     return SECSuccess;

 loser:
-    if (statusContext != NULL)
-       PORT_Free(statusContext);
     if (statusConfig != NULL)
        PORT_Free(statusConfig);
     return SECFailure;
(Reporter)

Comment 1

12 years ago
Created attachment 221265 [details] [diff] [review]
remove dead code in error path
Severity: normal → trivial
Priority: -- → P3
(Reporter)

Updated

12 years ago
Attachment #221265 - Flags: review?(wtchang)

Updated

12 years ago
Attachment #221265 - Flags: review?(wtchang) → review+
(Assignee)

Comment 2

12 years ago
trunk
/cvsroot/mozilla/security/nss/lib/certhigh/ocsp.c,v  <--  ocsp.c
new revision: 1.25; previous revision: 1.24

3.11 branch
/cvsroot/mozilla/security/nss/lib/certhigh/ocsp.c,v  <--  ocsp.c
new revision: 1.21.2.6; previous revision: 1.21.2.5
Assignee: nobody → alexei.volkov.bugs
(Assignee)

Updated

12 years ago
Status: NEW → RESOLVED
Last Resolved: 12 years ago
Resolution: --- → FIXED
Whiteboard: [CID 446]
Also CID 843
Whiteboard: [CID 446] → [CID 446 843]
You need to log in before you can comment on or make changes to this bug.