337091 - Horizontal scrollbar in add-ons manager when there shouldn't be

Status: RESOLVED WORKSFORME

(Toolkit :: Add-ons Manager, defect)

Description

[Robert Strong (they/them - no direct email)]

This only affects the trunk and I highly suspect this is a regression from bug 328881. Also, this is not fixed by the patch in bug 334765.

To reproduce:
1)  Launch a recent firefox trunk build
2)  Open Tools -> Add-ons Manager
3)  Install enough extensions to create a vertical scroll bar (not sure this is necessary)
4)  In the Extensions view deselect any extensions (e.g. ctrl + click)
5)  If there is a horizontal scrollbar increase the width of the window until it is not displayed.
5)  Switch to the Themes view
6   Switch back to the Extensions view

Actual Results:
A horizontal Scrollbar is displayed.

Expected Results:
A horizontal Scrollbar is *not* displayed.

Note: selecting an extension or resizing the window will make the horizontal scrollbar to disappear.

Comment 1

[Ria Klaassen (not reading all bugmail)]

I can't exactly reproduce how you describe it but I see now that the Add-ons manager shows the same behaviour as the customize window: see Bug 330673.

Comment 2

[Robert Strong (they/them - no direct email)]

It is quite possible this is due to bug 192767 as bug 330673 is thought to be. Has anyone backed out the patch from bug 192767 to see if it is to blame? Doesn't look like it from the comments in bug 330673. :(

Comment 3

[Ria Klaassen (not reading all bugmail)]

Please don't leave words out in the summary without an urgent reason for otherwise it becomes very hard to find the bug. 

Comment 4

[-fullmetaljacket-]

(In reply to comment #3)
> Please don't leave words out in the summary without an urgent reason for
> otherwise it becomes very hard to find the bug. 
> 

sorry for this bugspam:

yes i understand but "mgr" is not a valid word and it is making this bug hard to find, that is why i changed "mgr" to "manager".

Comment 5

[Ria Klaassen (not reading all bugmail)]

To avoid misunderstanding: when developers give it a different, more technical title, it has already drawn their attention and in that case it is less important for me what the name is.

Comment 6

[Ria Klaassen (not reading all bugmail)]

Hm, terribly sorry mr. Strong, I thought I was in Bug 330673. Are these duplicates?

Comment 7

[Ria Klaassen (not reading all bugmail)]

Terribly ashamed. It's still early here.

Comment 8

[Bill Gianopoulos [:WG9s]]

OK.  I can no longer recreate the original issue.  However there is a new issue, which is what people are now seeing.  This cannot be the issue originally reported last May because for this new issue I have narrowed down a regression window of

http://bonsai.mozilla.org/cvsquery.cgi?treeid=default&module=all&branch=HEAD&branchtype=match&dir=&file=&filetype=match&who=&whotype=match&sortby=Date&hours=2&date=explicit&mindate=2006-12-28+04%3A10&maxdate=2006-12-29+04%3A05&cvsroot=%2Fcvsroot

I don't see anything obvious here.  I will try to isolate it to an individual checkin.

Comment 9

[Bill Gianopoulos [:WG9s]]

(In reply to comment #8)
> OK.  I can no longer recreate the original issue.  However there is a new
> issue, which is what people are now seeing.  This cannot be the issue
> originally reported last May because for this new issue I have narrowed down a
> regression window of
> 
> http://bonsai.mozilla.org/cvsquery.cgi?treeid=default&module=all&branch=HEAD&branchtype=match&dir=&file=&filetype=match&who=&whotype=match&sortby=Date&hours=2&date=explicit&mindate=2006-12-28+04%3A10&maxdate=2006-12-29+04%3A05&cvsroot=%2Fcvsroot
> 
> I don't see anything obvious here.  I will try to isolate it to an individual
> checkin.
> 

Ah never mind, wrong regression window.  It was actually the day before.  I should have this down to a checkin by tomorrow.

Comment 10

[Peter van der Woude [:Peter6]]

(In reply to comment #9)
> (In reply to comment #8)
> > OK.  I can no longer recreate the original issue.  However there is a new
> > issue, which is what people are now seeing.  This cannot be the issue
> > originally reported last May because for this new issue I have narrowed down a
> > regression window of
> > 
> > http://bonsai.mozilla.org/cvsquery.cgi?treeid=default&module=all&branch=HEAD&branchtype=match&dir=&file=&filetype=match&who=&whotype=match&sortby=Date&hours=2&date=explicit&mindate=2006-12-28+04%3A10&maxdate=2006-12-29+04%3A05&cvsroot=%2Fcvsroot
> > 
> > I don't see anything obvious here.  I will try to isolate it to an individual
> > checkin.
> > 
> 
> Ah never mind, wrong regression window.  It was actually the day before.  I
> should have this down to a checkin by tomorrow.
> 
Yeah, this one is WFM

the new regression is Bug 365937