337105 - Coverity Crash [@ ssl2_ChooseSessionCypher] Variable "(ss)->preferredCipher" tracked as NULL was dereferenced.

Status: RESOLVED FIXED

(NSS :: Libraries, defect, P2)

Description

[timeless]

The code assumes that if there isn't a preferredCipher, it will select one. Coverity is concerned that it might not.

Comment 1

[Daniel Veditz [:dveditz]]

Confirming based on Nelson's P2

Comment 2

[Nelson Bolyard (seldom reads bugmail)]

Timeless, here again, the bug summary cites an ssl2 function, but the URL is
about funntion ssl3_CompressMACEncryptRecord in ssl3con.c.

What't this bug really about?

Comment 3

[Nelson Bolyard (seldom reads bugmail)]

Eliminated old bug URL, which was:
http://bonsai.mozilla.org/cvsblame.cgi?file=mozilla/security/nss/lib/ssl/ssl3con.c&rev=1.88&mark=1834-1835,1838-1840,1843,1858,1859,1860

Replaced it with this one:
http://bonsai.mozilla.org/cvsblame.cgi?file=mozilla/security/nss/lib/ssl/sslcon.c&rev=1.30&mark=1832,1839,1858-1860,#1831

For this bug, it is apparent that the problem with the old URL was merely 
that the file name was wrong in the hand-constructed URL.

Comment 4

[timeless]

sorry, yeah i was hand constructing and clearly had trouble pulling proper filenames :(.

Comment 5

[Nelson Bolyard (seldom reads bugmail)]

Checking in sslcon.c; new revision: 1.31;     previous revision: 1.30
Checking in sslcon.c; new revision: 1.28.2.3; previous revision: 1.28.2.2