Closed Bug 337139 Opened 15 years ago Closed 15 years ago

select1, hooking up a send to ev:xforms-select only works the first time

Categories

(Core Graveyard :: XForms, defect, P1)

defect

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: allan, Assigned: aaronr)

References

()

Details

(Keywords: fixed1.8.0.5, fixed1.8.1)

Attachments

(2 files)

If I hook up a send to an xforms-select on a xforms:select1, it only triggers the submission the first time. On subsequent selects I get this error:

Error: elm.parentNode has no properties
Source File: chrome://xforms/content/select1.xml
Line: 942
Attached file Testcase
Blocks: 331209
Priority: -- → P1
Possibly a dupe of 332292?
Attached patch Crude fixSplinter Review
Aparently the selected element does not always have a parent node? Checking for that makes the dispatchEvent() work.

It does not fix the testcase 100%, because the xforms-select event is sent before the node value is changed, so the result gotten from the server is "lagging". But it might be correct event sequencing? Dunno.
Attachment #223042 - Flags: review?(doronr)
Comment on attachment 223042 [details] [diff] [review]
Crude fix

ugh, you really should figure out why elm has no parentNode - you probably have a reference to an element no longer in the DOM.

Check is ok for a temp fix though (0.6)
Attachment #223042 - Flags: review?(doronr) → review+
Comment on attachment 223042 [details] [diff] [review]
Crude fix

something's wrong alright, but temp fix. for 0.6, please.
Attachment #223042 - Flags: review?(Olli.Pettay)
Comment on attachment 223042 [details] [diff] [review]
Crude fix

Could you put the whole
method inside CDATA.
& is just too ugly,
& is much better
With that r=me
Attachment #223042 - Flags: review?(Olli.Pettay) → review+
Fixed on trunk w/smaug's comment fixed
Status: NEW → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
Whiteboard: xf-to-branch
Blocks: 339062
Filed follow up bug 339062.
Keywords: fixed1.8.1
Keywords: fixed1.8.0.5
Whiteboard: xf-to-branch
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.