Closed
Bug 337205
Opened 18 years ago
Closed 18 years ago
Move docshell changes for session storage into a new interface
Categories
(Core :: DOM: Core & HTML, defect)
Tracking
()
RESOLVED
FIXED
mozilla1.8.1alpha2
People
(Reporter: enndeakin, Assigned: enndeakin)
References
Details
(Keywords: fixed1.8.1)
Attachments
(1 file)
4.73 KB,
patch
|
bzbarsky
:
review+
bzbarsky
:
superreview+
bzbarsky
:
approval-branch-1.8.1+
|
Details | Diff | Splinter Review |
bryner is concerned about shipping a variant nsIDocShell in alpha2, because he has a C++-based extension that he wants to have work in both 1.5 and 2.0a2. Given that there are different IIDs for the two nsIDocShells, I think that's feasible, and a relatively rare case. So in my opinion the current path is preferable to the other available choices (back out storage and not get impl feedback from interested web authors until b1; or slip the alpha for this bug to get fixed). But others' opinions might differ!
Comment 2•18 years ago
|
||
This reverts all the nsIDocShell changes in bug 335540 and splits them out into a nsIDocShell_MOZILLA_1_8_BRANCH interface. Pretty straight forward stuff.
Attachment #221393 -
Flags: superreview?(shaver)
Attachment #221393 -
Flags: review?(shaver)
Comment 3•18 years ago
|
||
This should block the release of "bon echo alpha 2" in my opinion.
Severity: normal → blocker
Flags: blocking1.8.1+
Target Milestone: --- → mozilla1.8.1alpha2
Comment 4•18 years ago
|
||
Comment on attachment 221393 [details] [diff] [review] Revert the changes to nsIDocShell and put them in a new interface r+sr+a=bzbarsky
Attachment #221393 -
Flags: superreview?(shaver)
Attachment #221393 -
Flags: superreview+
Attachment #221393 -
Flags: review?(shaver)
Attachment #221393 -
Flags: review+
Attachment #221393 -
Flags: approval-branch-1.8.1+
Comment 5•18 years ago
|
||
You should land this once the tree bustage is fixed.
jst landed this last night, FIXED.
Status: NEW → RESOLVED
Closed: 18 years ago
Resolution: --- → FIXED
Updated•18 years ago
|
Keywords: fixed1.8.1
Assignee | ||
Updated•17 years ago
|
Flags: in-testsuite-
Updated•5 years ago
|
Component: DOM → DOM: Core & HTML
You need to log in
before you can comment on or make changes to this bug.
Description
•