Closed Bug 337208 Opened 14 years ago Closed 14 years ago

build breaks if storage is not enabled because of DOM dependency

Categories

(Core :: DOM: Core & HTML, defect)

x86
All
defect
Not set

Tracking

()

RESOLVED FIXED

People

(Reporter: vlad, Assigned: benjamin)

References

Details

(Keywords: fixed1.8.1)

Attachments

(2 files, 1 obsolete file)

With the landing of the session/global storage stuff (bug 335540), DOM/docshell now has a hard dependency on storage.  It's only built by default for the "browser" application.  We need to either:

1) Build it by default everywhere (or just remove the config option);

2) Add appropriate #ifdefs in the implementation to return failure if MOZ_STORAGE is not enabled.
I vote for #1 (though not removing the config option, at least for now).
This will enable storage for all except the embedding "minimal" profile (no XUL). It will be enabled for minimo (which uses the embedding "basic" profile). I haven't discussed this out with dougt yet, so what happens to the basic profile is still in flux.
Assignee: general → benjamin
Status: NEW → ASSIGNED
Attachment #221468 - Flags: review?(shaver)
Since the branch doesn't have a concept of embedding profiles, this enables storage unconditionally.
Attachment #221469 - Flags: approval-branch-1.8.1?(shaver)
Comment on attachment 221469 [details] [diff] [review]
1.8branch, enable storage unconditionally, rev. 1

benjamin, can you please remove the MOZ_STORAGE=1 I had to add to mail last night as well?
Yeah, I've got that in my local tree with camino.
(In reply to comment #3)
> Created an attachment (id=221469) [edit]

so, shouldn't this line:
+MOZ_STORAGE=

be:
MOZ_STORAGE=1
?
Comment on attachment 221469 [details] [diff] [review]
1.8branch, enable storage unconditionally, rev. 1

Yes it should, I don't know what I was thinking.
Attachment #221469 - Attachment is obsolete: true
Attachment #221804 - Flags: approval-branch-1.8.1?(shaver)
Attachment #221469 - Flags: approval-branch-1.8.1?(shaver)
In case someone here wasn't aware, Neil and I have been working on making the DOM storage code build w/o MOZ_STORAGE defined, and when built that way session storage still works, but global storage doesn't. This is happening in the original DOM storage bug 335540.
Comment on attachment 221804 [details] [diff] [review]
1.8branch, enable storage unconditionally, rev. 1.1

181=shaver, woo.
Attachment #221804 - Flags: approval-branch-1.8.1?(shaver) → approval-branch-1.8.1+
Comment on attachment 221468 [details] [diff] [review]
Trunk, enable storage mostly-unconditionally, rev. 1

r=shaver.
Attachment #221468 - Flags: review?(shaver) → review+
Fixed on trunk and branch
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Keywords: fixed1.8.1
Resolution: --- → FIXED
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.