337208 - build breaks if storage is not enabled because of DOM dependency

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond)]

With the landing of the session/global storage stuff (bug 335540), DOM/docshell now has a hard dependency on storage.  It's only built by default for the "browser" application.  We need to either:

1) Build it by default everywhere (or just remove the config option);

2) Add appropriate #ifdefs in the implementation to return failure if MOZ_STORAGE is not enabled.

Comment 1

[Mike Shaver (:shaver -- probably not reading bugmail closely)]

I vote for #1 (though not removing the config option, at least for now).

Comment 2

[Benjamin Smedberg]

Attachment: Trunk, enable storage mostly-unconditionally, rev. 1

This will enable storage for all except the embedding "minimal" profile (no XUL). It will be enabled for minimo (which uses the embedding "basic" profile). I haven't discussed this out with dougt yet, so what happens to the basic profile is still in flux.

Comment 3

[Benjamin Smedberg]

Attachment: 1.8branch, enable storage unconditionally, rev. 1

Since the branch doesn't have a concept of embedding profiles, this enables storage unconditionally.

Comment 4

[Scott MacGregor]

Comment on attachment 221469 [details] [diff] [review]
1.8branch, enable storage unconditionally, rev. 1

benjamin, can you please remove the MOZ_STORAGE=1 I had to add to mail last night as well?

Comment 5

[Benjamin Smedberg]

Yeah, I've got that in my local tree with camino.

Comment 6

[Christian :Biesinger (don't email me, ping me on IRC)]

(In reply to comment #3)
> Created an attachment (id=221469) [edit]

so, shouldn't this line:
+MOZ_STORAGE=

be:
MOZ_STORAGE=1
?

Comment 7

[Benjamin Smedberg]

Comment on attachment 221469 [details] [diff] [review]
1.8branch, enable storage unconditionally, rev. 1

Yes it should, I don't know what I was thinking.

Comment 8

[Benjamin Smedberg]

Attachment: 1.8branch, enable storage unconditionally, rev. 1.1

Comment 9

[Johnny Stenback (:jst)]

In case someone here wasn't aware, Neil and I have been working on making the DOM storage code build w/o MOZ_STORAGE defined, and when built that way session storage still works, but global storage doesn't. This is happening in the original DOM storage bug 335540.

Comment 10

[Mike Shaver (:shaver -- probably not reading bugmail closely)]

Comment on attachment 221804 [details] [diff] [review]
1.8branch, enable storage unconditionally, rev. 1.1

181=shaver, woo.

Comment 11

[Mike Shaver (:shaver -- probably not reading bugmail closely)]

Comment on attachment 221468 [details] [diff] [review]
Trunk, enable storage mostly-unconditionally, rev. 1

r=shaver.

Comment 12

[Benjamin Smedberg]

Fixed on trunk and branch