337214 - broke build of GDI+ SVG rendering

Status: RESOLVED WONTFIX

(Firefox :: General, defect)

Description

[Roy Tam]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.0.4) Gecko/20060508 Firefox/1.5.0.4 (Firefox musume)
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.0.4) Gecko/20060508 Firefox/1.5.0.4 (Firefox musume)

the check-in of bug 333613 breaks the building of GDI+ SVG rendering

Reproducible: Always

Steps to Reproduce:
1.add "ac_add_options --enable-svg-renderer=gdiplus" into .mozconfig
2.build
Actual Results:  
compile error with GDI+ SVG component

mozilla\layout\svg\renderer\src\gdiplus\nsSVGGDIPlusCanvas.cpp(140) : error
C2664: 'nsIRenderingContext::RetrieveCurrentNativeGraphicData' : cannot convert
parameter 1 from 'PRUint32 *' to 'void ** '



Expected Results:  
compile without any problems.

Comment 1

[Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond)]

This is a 2-line fix, just use a void* instead of a PRUint32 for the HDC.

Comment 2

[Roy Tam]

(In reply to comment #1)
> This is a 2-line fix, just use a void* instead of a PRUint32 for the HDC.
> 

Could you please provide a patch for this?

Comment 3

[Mike Shaver (:shaver -- probably not reading bugmail closely)]

I don't think we should continue to support SVG-on-GDI on the branch, if we're not going to ship it, unless a strong owner appears from somewhere.  Tempting to WONTFIX and file on removing the config option until there's someone to actively maintain it.

Comment 4

[Stefan Ring]

There are more errors after that one.

d:/firefox/mozilla/layout/build/nsLayoutStatics.cpp(175) : error C2065: 'NS_InitSVGRendererGDIPlusGlobals' : undeclared identifier
d:/firefox/mozilla/layout/build/nsLayoutStatics.cpp(234) : error C2065: 'NS_FreeSVGRendererGDIPlusGlobals' : undeclared identifier
make[4]: *** [nsLayoutStatics.obj] Error 2

Which renderer does the official build use? I settled on GDI+ a while ago because it's the only one that worked for me. Both cairo and libart render badly distorted images.

Comment 5

[tor]

The official builds use cairo.

Comment 6

[Steve England [:stevee]]

WONTFIX?