Closed Bug 337214 Opened 18 years ago Closed 16 years ago
broke build of GDI+ SVG rendering
User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:22.214.171.124) Gecko/20060508 Firefox/126.96.36.199 (Firefox musume) Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:188.8.131.52) Gecko/20060508 Firefox/184.108.40.206 (Firefox musume) the check-in of bug 333613 breaks the building of GDI+ SVG rendering Reproducible: Always Steps to Reproduce: 1.add "ac_add_options --enable-svg-renderer=gdiplus" into .mozconfig 2.build Actual Results: compile error with GDI+ SVG component mozilla\layout\svg\renderer\src\gdiplus\nsSVGGDIPlusCanvas.cpp(140) : error C2664: 'nsIRenderingContext::RetrieveCurrentNativeGraphicData' : cannot convert parameter 1 from 'PRUint32 *' to 'void ** ' Expected Results: compile without any problems.
This is a 2-line fix, just use a void* instead of a PRUint32 for the HDC.
(In reply to comment #1) > This is a 2-line fix, just use a void* instead of a PRUint32 for the HDC. > Could you please provide a patch for this?
I don't think we should continue to support SVG-on-GDI on the branch, if we're not going to ship it, unless a strong owner appears from somewhere. Tempting to WONTFIX and file on removing the config option until there's someone to actively maintain it.
There are more errors after that one. d:/firefox/mozilla/layout/build/nsLayoutStatics.cpp(175) : error C2065: 'NS_InitSVGRendererGDIPlusGlobals' : undeclared identifier d:/firefox/mozilla/layout/build/nsLayoutStatics.cpp(234) : error C2065: 'NS_FreeSVGRendererGDIPlusGlobals' : undeclared identifier make: *** [nsLayoutStatics.obj] Error 2 Which renderer does the official build use? I settled on GDI+ a while ago because it's the only one that worked for me. Both cairo and libart render badly distorted images.
The official builds use cairo.
Version: unspecified → 1.5.0.x Branch
Status: UNCONFIRMED → RESOLVED
Closed: 16 years ago
Resolution: --- → WONTFIX
You need to log in before you can comment on or make changes to this bug.