337251 - warning: "/*" within comment

Status: RESOLVED FIXED

(NSS :: Libraries, defect, P5)

Description

[timeless]

pk11obj.c:1143:4: warning: "/*" within comment
pk11obj.c:1152:17: warning: "/*" within comment
pk11obj.c:1162:7: warning: "/*" within comment

could this please be addressed? i know it's sample code, but perhaps

#undef SAMPLE_CODE
#ifdef SAMPLE_CODE
...
#endif

would be better, then the code would be recognized by syntax highlighters, the /* embedded in the code */ would be treated as a comment and the compiler would not complain about it.

Comment 1

[Nelson Bolyard (seldom reads bugmail)]

Timeless, is this a coverity bug?

Comment 2

[timeless]

i didn't tag it as such, i have to presume it isn't. the syntax of the output here implies i was using gcc i believe.

Comment 3

[timeless]

Attachment: replace outer comments w/ #if 0 block and make sure {}s match

this bug is something i see whenever i build on boffo, because the build process hangs (for a relatively long time) while signing the nss library. as a result, i'm likely to see this annoying warning and want to file a bug about it. or today, post a patch :).

Comment 4

[Nelson Bolyard (seldom reads bugmail)]

Comment on attachment 241149 [details] [diff] [review]
replace outer comments w/ #if 0 block and make sure {}s match

r=nelson for the trunk (only), provided the patch still applies cleanly.

Comment 5

[timeless]

[e-mail]: i don't have commit privs (which is fairly annoying on its own given that i do touch the whole tree and play nicely by rules), would you please commit?

Comment 6

[Nelson Bolyard (seldom reads bugmail)]

On trunk
new revision: 1.17; previous revision: 1.16