Last Comment Bug 337251 - warning: "/*" within comment
: warning: "/*" within comment
Status: RESOLVED FIXED
:
Product: NSS
Classification: Components
Component: Libraries (show other bugs)
: 3.11
: x86 Linux
: P5 trivial (vote)
: 3.12
Assigned To: timeless
:
:
Mentors:
http://bonsai.mozilla.org/cvsblame.cg...
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2006-05-09 00:44 PDT by timeless
Modified: 2007-08-01 02:43 PDT (History)
1 user (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---


Attachments
replace outer comments w/ #if 0 block and make sure {}s match (2.67 KB, patch)
2006-10-04 00:05 PDT, timeless
nelson: review+
Details | Diff | Splinter Review

Description timeless 2006-05-09 00:44:00 PDT
pk11obj.c:1143:4: warning: "/*" within comment
pk11obj.c:1152:17: warning: "/*" within comment
pk11obj.c:1162:7: warning: "/*" within comment

could this please be addressed? i know it's sample code, but perhaps

#undef SAMPLE_CODE
#ifdef SAMPLE_CODE
...
#endif

would be better, then the code would be recognized by syntax highlighters, the /* embedded in the code */ would be treated as a comment and the compiler would not complain about it.
Comment 1 Nelson Bolyard (seldom reads bugmail) 2006-05-17 14:51:53 PDT
Timeless, is this a coverity bug?
Comment 2 timeless 2006-05-17 21:25:22 PDT
i didn't tag it as such, i have to presume it isn't. the syntax of the output here implies i was using gcc i believe.
Comment 3 timeless 2006-10-04 00:05:23 PDT
Created attachment 241149 [details] [diff] [review]
replace outer comments w/ #if 0 block and make sure {}s match

this bug is something i see whenever i build on boffo, because the build process hangs (for a relatively long time) while signing the nss library. as a result, i'm likely to see this annoying warning and want to file a bug about it. or today, post a patch :).
Comment 4 Nelson Bolyard (seldom reads bugmail) 2006-10-30 15:28:30 PST
Comment on attachment 241149 [details] [diff] [review]
replace outer comments w/ #if 0 block and make sure {}s match

r=nelson for the trunk (only), provided the patch still applies cleanly.
Comment 5 timeless 2007-07-30 00:53:49 PDT
nelson@bolyard.com: i don't have commit privs (which is fairly annoying on its own given that i do touch the whole tree and play nicely by rules), would you please commit?
Comment 6 Nelson Bolyard (seldom reads bugmail) 2007-08-01 02:43:21 PDT
On trunk
new revision: 1.17; previous revision: 1.16

Note You need to log in before you can comment on or make changes to this bug.